Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2080203003: Rename UseCounter::CSPWithUnsafeDynamic to UseCounter::CSPWithStrictDynamic. (Closed)

Created:
4 years, 6 months ago by mikispag
Modified:
4 years, 6 months ago
Reviewers:
Mike West, rkaplow
CC:
aaj, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, lwe, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename UseCounter::CSPWithUnsafeDynamic to UseCounter::CSPWithStrictDynamic. This change is due to the renaming of 'unsafe-dynamic' to 'strict-dynamic' (https://codereview.chromium.org/2082613002/). R=mkwst@chromium.org BUG=589380 Committed: https://crrev.com/adffa17038e400624bd017a0615c10ac1f3b15f0 Cr-Commit-Position: refs/heads/master@{#400990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
mikispag
4 years, 6 months ago (2016-06-20 16:35:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080203003/1
4 years, 6 months ago (2016-06-20 16:36:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 18:06:13 UTC) #6
Mike West
LGTM. Please change the bug number to 589380. rkaplow@: Would you mind stamping the trivial ...
4 years, 6 months ago (2016-06-21 07:42:16 UTC) #8
mikispag
On 2016/06/21 07:42:16, Mike West (OOO - BlinkOn) wrote: > LGTM. > > Please change ...
4 years, 6 months ago (2016-06-21 12:45:48 UTC) #10
rkaplow
lgtm
4 years, 6 months ago (2016-06-21 14:37:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080203003/1
4 years, 6 months ago (2016-06-21 14:39:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 14:43:49 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:45:26 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adffa17038e400624bd017a0615c10ac1f3b15f0
Cr-Commit-Position: refs/heads/master@{#400990}

Powered by Google App Engine
This is Rietveld 408576698