Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2080183003: Only count legacy parser usage if legacy parser had effect. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only count legacy parser usage if legacy parser had effect. We would otherwise also count if its just trimming whitespaces. R=adamk@chromium.org BUG=chromium:618595 Committed: https://crrev.com/8b67a002231c222314170a13187e31a2b361ef91 Cr-Commit-Position: refs/heads/master@{#37197}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/dateparser-inl.h View 3 chunks +4 lines, -1 line 0 comments Download
M test/cctest/test-date.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yang
4 years, 6 months ago (2016-06-21 06:52:12 UTC) #1
adamk
Change seems fine, but how about adding a few tests? You could do this pretty ...
4 years, 6 months ago (2016-06-21 16:11:40 UTC) #2
Yang
On 2016/06/21 16:11:40, adamk wrote: > Change seems fine, but how about adding a few ...
4 years, 6 months ago (2016-06-22 12:56:46 UTC) #3
adamk
lgtm
4 years, 6 months ago (2016-06-22 17:41:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080183003/20001
4 years, 6 months ago (2016-06-22 17:41:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 18:06:41 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:08:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b67a002231c222314170a13187e31a2b361ef91
Cr-Commit-Position: refs/heads/master@{#37197}

Powered by Google App Engine
This is Rietveld 408576698