Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2080183002: Revert "Enforce use of the forEachInstanceField ordering for constructed constants." (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Enforce use of the forEachInstanceField ordering for constructed constants." This reverts commit 67b71d0cb793d5faaa2ee6f070741cc775a3f59a. BUG= Committed: https://github.com/dart-lang/sdk/commit/f817910fd03d49b42ec10346ae6f589d3dadae4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
TBR
4 years, 6 months ago (2016-06-20 09:16:53 UTC) #1
Johnni Winther
4 years, 6 months ago (2016-06-20 09:17:01 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as f817910fd03d49b42ec10346ae6f589d3dadae4e (presubmit successful).
4 years, 6 months ago (2016-06-20 09:17:20 UTC) #5
Harry Terkelsen
4 years, 6 months ago (2016-06-20 16:06:29 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698