DevTools: pass theme name to the extensions.

DevTools: pass theme name to the extensions.
BUG=608869
Committed: https://crrev.com/426dd8915fd31f70e7dcb37de79e3975a66b72fd
Cr-Commit-Position: refs/heads/master@{#404076}

[pfeldman, 2016-06-20 11:34:52]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[pfeldman, 2016-06-20 21:10:00]

Description was changed from

==========
DevTools: pass theme name to the extensions.
BUG=608869
==========

to

==========
DevTools: pass theme name to the extensions.
BUG=608869
==========

[pfeldman, 2016-06-20 21:10:00]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[caseq, 2016-06-21 09:50:09]

This needs a test, a rebaseline of existent tests and an update of the docs in
chrome/common/extensions/api/devtools/panels.json

https://codereview.chromium.org/2080173003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
(right):

https://codereview.chromium.org/2080173003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js:980:
chrome.devtools.panels.themeName = themeName;
Let's either make it a function, a getter or an immutable property.

[pfeldman, 2016-06-27 15:13:21]

Don't want to document it just yet!

https://codereview.chromium.org/2080173003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
(right):

https://codereview.chromium.org/2080173003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js:980:
chrome.devtools.panels.themeName = themeName;
I can't make it immutable for the backwards compat reasons. And I don't know how
function is better!

[caseq, 2016-07-06 21:01:41]

lgtm

[pfeldman, 2016-07-06 21:01:55]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-06 21:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 22:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 22:18:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-07-07 00:30:09]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-07-07 00:30:09]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2080173003/#ps40001
(title: "test rebaselined")

[commit-bot: I haz the power, 2016-07-07 00:30:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 02:54:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 02:54:58]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-07-07 03:30:28]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-07 03:30:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 04:48:23]

Description was changed from

==========
DevTools: pass theme name to the extensions.
BUG=608869
==========

to

==========
DevTools: pass theme name to the extensions.
BUG=608869
==========

[commit-bot: I haz the power, 2016-07-07 04:48:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-07 04:48:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 04:50:15]

Description was changed from

==========
DevTools: pass theme name to the extensions.
BUG=608869
==========

to

==========
DevTools: pass theme name to the extensions.
BUG=608869

Committed: https://crrev.com/426dd8915fd31f70e7dcb37de79e3975a66b72fd
Cr-Commit-Position: refs/heads/master@{#404076}
==========

[commit-bot: I haz the power, 2016-07-07 04:50:17]

Patchset 3 (id:??) landed as
https://crrev.com/426dd8915fd31f70e7dcb37de79e3975a66b72fd
Cr-Commit-Position: refs/heads/master@{#404076}