Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/assembler.cc

Issue 2080173002: [debug] always add debug slot for statements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.h ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index b93149407e8709b0666e2baa833c44f860439ff0..be196f7e2181ee04a656ace2692ccddeb3d3ac9e 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1826,7 +1826,7 @@ std::ostream& operator<<(std::ostream& os, ExternalReference reference) {
return os;
}
-bool AssemblerPositionsRecorder::RecordPosition(int pos) {
+void AssemblerPositionsRecorder::RecordPosition(int pos) {
DCHECK(pos != RelocInfo::kNoPosition);
DCHECK(pos >= 0);
current_position_ = pos;
@@ -1834,10 +1834,10 @@ bool AssemblerPositionsRecorder::RecordPosition(int pos) {
CodeLinePosInfoAddPositionEvent(jit_handler_data_,
assembler_->pc_offset(),
pos));
- return WriteRecordedPositions();
+ WriteRecordedPositions();
}
-bool AssemblerPositionsRecorder::RecordStatementPosition(int pos) {
+void AssemblerPositionsRecorder::RecordStatementPosition(int pos) {
DCHECK(pos != RelocInfo::kNoPosition);
DCHECK(pos >= 0);
current_statement_position_ = pos;
@@ -1846,12 +1846,10 @@ bool AssemblerPositionsRecorder::RecordStatementPosition(int pos) {
jit_handler_data_,
assembler_->pc_offset(),
pos));
- return RecordPosition(pos);
+ RecordPosition(pos);
}
-bool AssemblerPositionsRecorder::WriteRecordedPositions() {
- bool written = false;
-
+void AssemblerPositionsRecorder::WriteRecordedPositions() {
// Write the statement position if it is different from what was written last
// time.
if (current_statement_position_ != written_statement_position_) {
@@ -1860,7 +1858,6 @@ bool AssemblerPositionsRecorder::WriteRecordedPositions() {
current_statement_position_);
written_position_ = current_statement_position_;
written_statement_position_ = current_statement_position_;
- written = true;
}
// Write the position if it is different from what was written last time and
@@ -1869,11 +1866,7 @@ bool AssemblerPositionsRecorder::WriteRecordedPositions() {
EnsureSpace ensure_space(assembler_);
assembler_->RecordRelocInfo(RelocInfo::POSITION, current_position_);
written_position_ = current_position_;
- written = true;
}
-
- // Return whether something was written.
- return written;
}
« no previous file with comments | « src/assembler.h ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698