DevTools: Create end-to-end test for chrome://inspect

DevTools: Create end-to-end test for chrome://inspect

BUG=354854
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260153

[Dmitry Zvorygin, 2014-03-25 08:57:19]

On 2014/03/24 13:36:33, Vladislav Kaznacheev wrote:

LGTM, though, I don't like test code in production.

[Vladislav Kaznacheev, 2014-03-25 13:02:47]

PTAL

[pfeldman, 2014-03-26 09:18:44]

lgtm

https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/browser/ui...
File chrome/browser/ui/webui/extensions/extension_settings_browsertest.h
(right):

https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/browser/ui...
chrome/browser/ui/webui/extensions/extension_settings_browsertest.h:37: // 
const extensions::Extension* InstallExtension(const base::FilePath& path);
Please revert.

https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/test/data/...
File chrome/test/data/webui/inspect_ui_test.js (right):

https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/test/data/...
chrome/test/data/webui/inspect_ui_test.js:12: setTimeout(check, 100);
timeout in tests is a 100% guarantee of flake. you should sniff the populate
method instead and timeout upon failure.

[Vladislav Kaznacheev, 2014-03-27 08:02:02]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-03-27 08:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/208013003/110001

[commit-bot: I haz the power, 2014-03-27 08:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 08:44:41]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Vladislav Kaznacheev, 2014-03-27 09:26:49]

Hi Finnur,

Please review the change to
chrome/browser/ui/webui/extensions/extension_settings_browsertest.h

I need this change becase I need to load an extension in my test. Inheriting my
test from ExtensionSettingsUIBrowserTest seemed the easiest way.

[Finnur, 2014-03-27 11:02:39]

We have public utility functions to do that (see extension_file_util). Does that
not work?

[Vladislav Kaznacheev, 2014-03-28 13:58:03]

On 2014/03/27 11:02:39, Finnur wrote:
> We have public utility functions to do that (see extension_file_util). Does
that
> not work?

That would probably be better. I am removing the extension related code from
this patch for now and will do this separately.

[Vladislav Kaznacheev, 2014-03-28 13:58:11]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-03-28 14:00:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/208013003/150001

[commit-bot: I haz the power, 2014-03-28 16:24:15]

Change committed as 260153