Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 208013003: DevTools: Create end-to-end test for chrome://inspect (Closed)

Created:
6 years, 9 months ago by Vladislav Kaznacheev
Modified:
6 years, 9 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, arv+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: Create end-to-end test for chrome://inspect BUG=354854 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260153

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Reimplemented as WebUIBrowserTest #

Total comments: 2

Patch Set 4 : Addressed comments #

Patch Set 5 : Removed extension test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -22 lines) Patch
M chrome/browser/devtools/android_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_adb_bridge_browsertest.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 1 2 3 4 3 chunks +40 lines, -20 lines 0 comments Download
A chrome/test/data/webui/inspect_ui_test.js View 1 2 3 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Vladislav Kaznacheev
6 years, 9 months ago (2014-03-24 13:36:33 UTC) #1
Dmitry Zvorygin
On 2014/03/24 13:36:33, Vladislav Kaznacheev wrote: LGTM, though, I don't like test code in production.
6 years, 9 months ago (2014-03-25 08:57:19 UTC) #2
Vladislav Kaznacheev
PTAL
6 years, 9 months ago (2014-03-25 13:02:47 UTC) #3
pfeldman
lgtm https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h File chrome/browser/ui/webui/extensions/extension_settings_browsertest.h (right): https://chromiumcodereview.appspot.com/208013003/diff/40001/chrome/browser/ui/webui/extensions/extension_settings_browsertest.h#newcode37 chrome/browser/ui/webui/extensions/extension_settings_browsertest.h:37: // const extensions::Extension* InstallExtension(const base::FilePath& path); Please revert. ...
6 years, 9 months ago (2014-03-26 09:18:44 UTC) #4
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 9 months ago (2014-03-27 08:02:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/208013003/110001
6 years, 9 months ago (2014-03-27 08:02:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 08:44:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57793
6 years, 9 months ago (2014-03-27 08:44:41 UTC) #8
Vladislav Kaznacheev
Hi Finnur, Please review the change to chrome/browser/ui/webui/extensions/extension_settings_browsertest.h I need this change becase I need ...
6 years, 9 months ago (2014-03-27 09:26:49 UTC) #9
Finnur
We have public utility functions to do that (see extension_file_util). Does that not work?
6 years, 9 months ago (2014-03-27 11:02:39 UTC) #10
Vladislav Kaznacheev
On 2014/03/27 11:02:39, Finnur wrote: > We have public utility functions to do that (see ...
6 years, 9 months ago (2014-03-28 13:58:03 UTC) #11
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 9 months ago (2014-03-28 13:58:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/208013003/150001
6 years, 9 months ago (2014-03-28 14:00:04 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 16:24:15 UTC) #14
Message was sent while issue was closed.
Change committed as 260153

Powered by Google App Engine
This is Rietveld 408576698