Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2080123003: Remove ios web shell MainView.xib. (Closed)

Created:
4 years, 6 months ago by lpromero
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ios web shell MainView.xib. BUG=621377, 499591 R=marq@chromium.org Committed: https://crrev.com/d89f616bea0cd60e5d5d096d7bfa8d3256412411 Cr-Commit-Position: refs/heads/master@{#401573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -54 lines) Patch
M ios/web/ios_web_shell_exe.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/shell/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D ios/web/shell/MainView.xib View 1 chunk +0 lines, -43 lines 0 comments Download
M ios/web/shell/view_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/shell/view_controller.mm View 3 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080123003/1
4 years, 6 months ago (2016-06-20 08:22:01 UTC) #2
lpromero
4 years, 6 months ago (2016-06-20 08:22:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 09:24:47 UTC) #5
lpromero
Kindly ping
4 years, 6 months ago (2016-06-21 08:55:35 UTC) #6
lpromero
Ping to remove this xib
4 years, 6 months ago (2016-06-22 22:00:08 UTC) #7
marq (ping after 24h)
lgtm
4 years, 6 months ago (2016-06-23 08:58:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080123003/1
4 years, 6 months ago (2016-06-23 09:04:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 09:59:14 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 10:01:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d89f616bea0cd60e5d5d096d7bfa8d3256412411
Cr-Commit-Position: refs/heads/master@{#401573}

Powered by Google App Engine
This is Rietveld 408576698