Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2080093002: [turbofan] Allow truncating minus zero in add, sub, mul if we have word32 truncation. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Allow truncating minus zero in add, sub, mul if we have word32 truncation. Committed: https://crrev.com/a8b5e235d3f2ad7443dd4328c13b69efb9199b5d Cr-Commit-Position: refs/heads/master@{#37080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/type-cache.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-19 15:18:43 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-19 18:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080093002/1
4 years, 6 months ago (2016-06-19 18:02:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-19 18:04:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-19 18:04:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8b5e235d3f2ad7443dd4328c13b69efb9199b5d
Cr-Commit-Position: refs/heads/master@{#37080}

Powered by Google App Engine
This is Rietveld 408576698