net/proxy/proxy_resolver_factory_mojo.cc - Issue 2080083002: Revert of Deletes mojo::Callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_factory_mojo.cc

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_factory_mojo.cc

diff --git a/net/proxy/proxy_resolver_factory_mojo.cc b/net/proxy/proxy_resolver_factory_mojo.cc

index f831c5282cb62b03309b37fbca594df22311a5da..e79db623447a527c81042ed519965b1473ab5f6d 100644

--- a/net/proxy/proxy_resolver_factory_mojo.cc

+++ b/net/proxy/proxy_resolver_factory_mojo.cc

@@ -8,7 +8,6 @@

#include <utility>

#include "base/bind.h"

-#include "base/callback.h"

#include "base/logging.h"

#include "base/macros.h"

#include "base/stl_util.h"

@@ -354,8 +353,8 @@

private:

void ReportResult(int32_t error) override {

- resolver_ptr_.set_connection_error_handler(base::Closure());

- binding_.set_connection_error_handler(base::Closure());

+ resolver_ptr_.set_connection_error_handler(mojo::Closure());

+ binding_.set_connection_error_handler(mojo::Closure());

if (error == OK) {

resolver_->reset(new ProxyResolverMojo(

std::move(resolver_ptr_), factory_->host_resolver_,