services/shell/public/cpp/lib/connection_impl.cc - Issue 2080083002: Revert of Deletes mojo::Callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/lib/connection_impl.cc

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/shell/public/cpp/lib/connection_impl.cc

diff --git a/services/shell/public/cpp/lib/connection_impl.cc b/services/shell/public/cpp/lib/connection_impl.cc

index 3a612e05fe0b6baf497c077dc90816066b8a783e..0be3d303dbdf9c845279ad47799c16eec868eb5f 100644

--- a/services/shell/public/cpp/lib/connection_impl.cc

+++ b/services/shell/public/cpp/lib/connection_impl.cc

@@ -85,7 +85,7 @@

}

void ConnectionImpl::AddConnectionCompletedClosure(

- const base::Closure& callback) {

+ const mojo::Closure& callback) {

if (IsPending())

connection_completed_callbacks_.push_back(callback);

else

@@ -126,7 +126,7 @@

State::CONNECTED : State::DISCONNECTED;

remote_id_ = target_application_id;

remote_.set_user_id(target_user_id);

- std::vector<base::Closure> callbacks;

+ std::vector<mojo::Closure> callbacks;

callbacks.swap(connection_completed_callbacks_);

for (auto callback : callbacks)

callback.Run();