Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc b/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
index 0f438598eb41822b6de9f73853bf3c7f60aac815..6f00d2e980dde1c9d4c840b99f7da9ce989b211d 100644
--- a/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
@@ -51,7 +51,7 @@
public:
InterfaceImpl()
: last_server_value_seen_(0),
- callback_saved_(new EchoIntCallback) {}
+ callback_saved_(new Callback<void(int32_t)>()) {}
~InterfaceImpl() override {
if (callback_saved_) {
@@ -78,7 +78,7 @@
// sample::Provider implementation
// Saves its two input values in member variables and does nothing else.
- void EchoInt(int32_t x, const EchoIntCallback& callback) override {
+ void EchoInt(int32_t x, const Callback<void(int32_t)>& callback) override {
last_server_value_seen_ = x;
*callback_saved_ = callback;
if (!closure_.is_null()) {
@@ -88,23 +88,24 @@
}
void EchoString(const String& a,
- const EchoStringCallback& callback) override {
+ const Callback<void(String)>& callback) override {
CHECK(false) << "Not implemented.";
}
void EchoStrings(const String& a,
const String& b,
- const EchoStringsCallback& callback) override {
+ const Callback<void(String, String)>& callback) override {
CHECK(false) << "Not implemented.";
}
void EchoMessagePipeHandle(
ScopedMessagePipeHandle a,
- const EchoMessagePipeHandleCallback& callback) override {
+ const Callback<void(ScopedMessagePipeHandle)>& callback) override {
CHECK(false) << "Not implemented.";
}
- void EchoEnum(sample::Enum a, const EchoEnumCallback& callback) override {
+ void EchoEnum(sample::Enum a,
+ const Callback<void(sample::Enum)>& callback) override {
CHECK(false) << "Not implemented.";
}
@@ -116,7 +117,7 @@
private:
int32_t last_server_value_seen_;
- EchoIntCallback* callback_saved_;
+ Callback<void(int32_t)>* callback_saved_;
base::Closure closure_;
};
« no previous file with comments | « mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc ('k') | mojo/public/cpp/bindings/tests/bindings_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698