Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 2bdc3e9029b4cc9b4334bf8576ffe27930700b7d..44fb0e10fa36897dc12fa01d084d7f756200b6d5 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -10,7 +10,6 @@
#include <memory>
#include <string>
-#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/containers/hash_tables.h"
#include "base/gtest_prod_util.h"
@@ -34,6 +33,10 @@
struct PresentationSessionMessage;
class RenderFrameHost;
+using NewSessionMojoCallback =
+ mojo::Callback<void(blink::mojom::PresentationSessionInfoPtr,
+ blink::mojom::PresentationErrorPtr)>;
+
// Implementation of Mojo PresentationService.
// It handles Presentation API requests coming from Blink / renderer process
// and delegates the requests to the embedder's media router via
@@ -47,10 +50,6 @@
public WebContentsObserver,
public PresentationServiceDelegate::Observer {
public:
- using NewSessionCallback =
- base::Callback<void(blink::mojom::PresentationSessionInfoPtr,
- blink::mojom::PresentationErrorPtr)>;
-
~PresentationServiceImpl() override;
// Static factory method to create an instance of PresentationServiceImpl.
@@ -96,9 +95,11 @@
// Maximum number of pending JoinSession requests at any given time.
static const int kMaxNumQueuedSessionRequests = 10;
+ using PresentationSessionMojoCallback =
+ mojo::Callback<void(blink::mojom::PresentationSessionInfoPtr)>;
using SessionMessagesCallback =
- base::Callback<void(mojo::Array<blink::mojom::SessionMessagePtr>)>;
- using SendSessionMessageCallback = base::Callback<void(bool)>;
+ mojo::Callback<void(mojo::Array<blink::mojom::SessionMessagePtr>)>;
+ using SendMessageMojoCallback = mojo::Callback<void(bool)>;
// Listener implementation owned by PresentationServiceImpl. An instance of
// this is created when PresentationRequest.getAvailability() is resolved.
@@ -122,21 +123,21 @@
PresentationServiceImpl* const service_;
};
- // Ensures the provided NewSessionCallback is invoked exactly once
+ // Ensures the provided NewSessionMojoCallback is invoked exactly once
// before it goes out of scope.
- class NewSessionCallbackWrapper {
+ class NewSessionMojoCallbackWrapper {
public:
- explicit NewSessionCallbackWrapper(
- const NewSessionCallback& callback);
- ~NewSessionCallbackWrapper();
+ explicit NewSessionMojoCallbackWrapper(
+ const NewSessionMojoCallback& callback);
+ ~NewSessionMojoCallbackWrapper();
void Run(blink::mojom::PresentationSessionInfoPtr session,
blink::mojom::PresentationErrorPtr error);
private:
- NewSessionCallback callback_;
-
- DISALLOW_COPY_AND_ASSIGN(NewSessionCallbackWrapper);
+ NewSessionMojoCallback callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(NewSessionMojoCallbackWrapper);
};
// |render_frame_host|: The RFH this instance is associated with.
@@ -155,14 +156,14 @@
void StopListeningForScreenAvailability(const mojo::String& url) override;
void StartSession(
const mojo::String& presentation_url,
- const NewSessionCallback& callback) override;
+ const NewSessionMojoCallback& callback) override;
void JoinSession(
const mojo::String& presentation_url,
const mojo::String& presentation_id,
- const NewSessionCallback& callback) override;
+ const NewSessionMojoCallback& callback) override;
void SendSessionMessage(blink::mojom::PresentationSessionInfoPtr session_info,
blink::mojom::SessionMessagePtr session_message,
- const SendSessionMessageCallback& callback) override;
+ const SendMessageMojoCallback& callback) override;
void CloseConnection(const mojo::String& presentation_url,
const mojo::String& presentation_id) override;
void Terminate(const mojo::String& presentation_url,
@@ -235,7 +236,7 @@
// Associates a JoinSession |callback| with a unique request ID and
// stores it in a map.
// Returns a positive value on success.
- int RegisterJoinSessionCallback(const NewSessionCallback& callback);
+ int RegisterJoinSessionCallback(const NewSessionMojoCallback& callback);
// Invoked by the embedder's PresentationServiceDelegate when a
// PresentationConnection's state has changed.
@@ -263,10 +264,10 @@
// For StartSession requests.
// Set to a positive value when a StartSession request is being processed.
int start_session_request_id_;
- std::unique_ptr<NewSessionCallbackWrapper> pending_start_session_cb_;
+ std::unique_ptr<NewSessionMojoCallbackWrapper> pending_start_session_cb_;
// For JoinSession requests.
- base::hash_map<int, linked_ptr<NewSessionCallbackWrapper>>
+ base::hash_map<int, linked_ptr<NewSessionMojoCallbackWrapper>>
pending_join_session_cbs_;
// RAII binding of |this| to an Presentation interface request.
@@ -274,7 +275,7 @@
std::unique_ptr<mojo::Binding<blink::mojom::PresentationService>> binding_;
// There can be only one send message request at a time.
- std::unique_ptr<SendSessionMessageCallback> send_message_callback_;
+ std::unique_ptr<SendMessageMojoCallback> send_message_callback_;
std::unique_ptr<SessionMessagesCallback> on_session_messages_callback_;
« no previous file with comments | « content/browser/permissions/permission_service_impl.cc ('k') | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698