Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: mojo/public/cpp/bindings/tests/connector_unittest.cc

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/connector.h" 5 #include "mojo/public/cpp/bindings/lib/connector.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdlib.h> 8 #include <stdlib.h>
9 #include <string.h> 9 #include <string.h>
10 #include <utility> 10 #include <utility>
11 11
12 #include "base/bind.h" 12 #include "base/bind.h"
13 #include "base/callback.h"
14 #include "base/callback_helpers.h"
15 #include "base/message_loop/message_loop.h" 13 #include "base/message_loop/message_loop.h"
16 #include "base/run_loop.h" 14 #include "base/run_loop.h"
17 #include "base/threading/thread_task_runner_handle.h" 15 #include "base/threading/thread_task_runner_handle.h"
18 #include "mojo/public/cpp/bindings/lib/message_builder.h" 16 #include "mojo/public/cpp/bindings/lib/message_builder.h"
19 #include "mojo/public/cpp/bindings/tests/message_queue.h" 17 #include "mojo/public/cpp/bindings/tests/message_queue.h"
20 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
21 19
22 namespace mojo { 20 namespace mojo {
23 namespace test { 21 namespace test {
24 namespace { 22 namespace {
25 23
26 class MessageAccumulator : public MessageReceiver { 24 class MessageAccumulator : public MessageReceiver {
27 public: 25 public:
28 MessageAccumulator() {} 26 MessageAccumulator() {}
29 explicit MessageAccumulator(const base::Closure& closure) 27 explicit MessageAccumulator(const Closure& closure) : closure_(closure) {}
30 : closure_(closure) {}
31 28
32 bool Accept(Message* message) override { 29 bool Accept(Message* message) override {
33 queue_.Push(message); 30 queue_.Push(message);
34 if (!closure_.is_null()) 31 if (!closure_.is_null()) {
35 base::ResetAndReturn(&closure_).Run(); 32 Closure closure = closure_;
33 closure_.Reset();
34 closure.Run();
35 }
36 return true; 36 return true;
37 } 37 }
38 38
39 bool IsEmpty() const { return queue_.IsEmpty(); } 39 bool IsEmpty() const { return queue_.IsEmpty(); }
40 40
41 void Pop(Message* message) { queue_.Pop(message); } 41 void Pop(Message* message) { queue_.Pop(message); }
42 42
43 void set_closure(const base::Closure& closure) { closure_ = closure; } 43 void set_closure(const Closure& closure) { closure_ = closure; }
44 44
45 size_t size() const { return queue_.size(); } 45 size_t size() const { return queue_.size(); }
46 46
47 private: 47 private:
48 MessageQueue queue_; 48 MessageQueue queue_;
49 base::Closure closure_; 49 Closure closure_;
50 }; 50 };
51 51
52 class ConnectorDeletingMessageAccumulator : public MessageAccumulator { 52 class ConnectorDeletingMessageAccumulator : public MessageAccumulator {
53 public: 53 public:
54 ConnectorDeletingMessageAccumulator(internal::Connector** connector) 54 ConnectorDeletingMessageAccumulator(internal::Connector** connector)
55 : connector_(connector) {} 55 : connector_(connector) {}
56 56
57 bool Accept(Message* message) override { 57 bool Accept(Message* message) override {
58 delete *connector_; 58 delete *connector_;
59 *connector_ = nullptr; 59 *connector_ = nullptr;
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
592 connector1.set_incoming_receiver(&accumulator); 592 connector1.set_incoming_receiver(&accumulator);
593 593
594 run_loop.Run(); 594 run_loop.Run();
595 595
596 ASSERT_EQ(2u, accumulator.size()); 596 ASSERT_EQ(2u, accumulator.size());
597 } 597 }
598 598
599 } // namespace 599 } // namespace
600 } // namespace test 600 } // namespace test
601 } // namespace mojo 601 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/tests/bindings_perftest.cc ('k') | mojo/public/cpp/bindings/tests/handle_passing_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698