Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: media/capture/video/scoped_result_callback.h

Issue 2080083002: Revert of Deletes mojo::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/mojo/ipc_mojo_bootstrap.cc ('k') | media/capture/video/video_capture_device.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_ 5 #ifndef MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_
6 #define MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_ 6 #define MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback_forward.h"
9 #include "base/callback_helpers.h"
10 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "mojo/public/cpp/bindings/callback.h"
11 11
12 namespace media { 12 namespace media {
13 13
14 // This class guarantees that |callback_| has either been called or will pass it 14 // This class guarantees that |callback_| has either been called or will pass it
15 // to |on_error_callback_| on destruction. Inspired by ScopedWebCallbacks<>. 15 // to |on_error_callback_| on destruction. Inspired by ScopedWebCallbacks<>.
16 template <typename CallbackType> 16 template <typename CallbackType>
17 class ScopedResultCallback { 17 class ScopedResultCallback {
18 public: 18 public:
19 using OnErrorCallback = base::Callback<void(const CallbackType&)>; 19 using OnErrorCallback = base::Callback<void(const CallbackType&)>;
20 ScopedResultCallback(const CallbackType& callback, 20 ScopedResultCallback(const CallbackType& callback,
(...skipping 13 matching lines...) Expand all
34 callback_ = other.callback_; 34 callback_ = other.callback_;
35 other.callback_.Reset(); 35 other.callback_.Reset();
36 on_error_callback_ = other.on_error_callback_; 36 on_error_callback_ = other.on_error_callback_;
37 other.on_error_callback_.Reset(); 37 other.on_error_callback_.Reset();
38 return *this; 38 return *this;
39 } 39 }
40 40
41 template <typename... Args> 41 template <typename... Args>
42 void Run(Args... args) { 42 void Run(Args... args) {
43 on_error_callback_.Reset(); 43 on_error_callback_.Reset();
44 base::ResetAndReturn(&callback_).Run(std::forward<Args>(args)...); 44 // TODO(mcasas): Use base::ResetAndReturn() when mojo::Callback<> is
45 // compatible with base::Callback<>, see https://crbug.com/596521.
46 callback_.Run(std::forward<Args>(args)...);
47 callback_.Reset();
45 } 48 }
46 49
47 private: 50 private:
48 CallbackType callback_; 51 CallbackType callback_;
49 OnErrorCallback on_error_callback_; 52 OnErrorCallback on_error_callback_;
50 53
51 DISALLOW_COPY_AND_ASSIGN(ScopedResultCallback); 54 DISALLOW_COPY_AND_ASSIGN(ScopedResultCallback);
52 }; 55 };
53 56
54 } // namespace media 57 } // namespace media
55 58
56 #endif // MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_ 59 #endif // MEDIA_CAPTURE_VIDEO_SCOPED_RESULT_CALLBACK_H_
OLDNEW
« no previous file with comments | « ipc/mojo/ipc_mojo_bootstrap.cc ('k') | media/capture/video/video_capture_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698