LayoutTests/fast/canvas/draw-focus-if-needed.html - Issue 208003003: Rename drawSystemFocusRing() to drawFocusIfNeeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/draw-focus-if-needed.html

Issue 208003003: Rename drawSystemFocusRing() to drawFocusIfNeeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/canvas/draw-focus-if-needed.html

diff --git a/LayoutTests/fast/canvas/draw-system-focus-ring.html b/LayoutTests/fast/canvas/draw-focus-if-needed.html

similarity index 78%

rename from LayoutTests/fast/canvas/draw-system-focus-ring.html

rename to LayoutTests/fast/canvas/draw-focus-if-needed.html

index 5204f5c336ebf3ebe08eaae184918a919b8bb29b..f5f48143d1ae27769eed034f123c4e4186120cc2 100644

--- a/LayoutTests/fast/canvas/draw-system-focus-ring.html

+++ b/LayoutTests/fast/canvas/draw-focus-if-needed.html

@@ -1,6 +1,6 @@

<!DOCTYPE HTML>

<head>

-<title>Canvas test: drawSystemFocusRing</title>

+<title>Canvas test: drawFocusIfNeeded</title>

</head>

@@ -16,22 +16,22 @@ document.getElementById("button1").focus();

var canvas = document.getElementById("canvas").getContext("2d");

-shouldNotThrow('canvas.drawSystemFocusRing(null);');

-shouldThrow('canvas.drawSystemFocusRing();');

+shouldNotThrow('canvas.drawFocusIfNeeded(null);');

+shouldThrow('canvas.drawFocusIfNeeded();');

canvas.beginPath();

canvas.rect(50, 50, 200, 100);

canvas.fillStyle = "#ccf";

canvas.fill();

// re-test null case after having defined a path (regression test for crbug.com/353248)

-shouldNotThrow('canvas.drawSystemFocusRing(null);');

-canvas.drawSystemFocusRing(document.getElementById("button1"));

+shouldNotThrow('canvas.drawFocusIfNeeded(null);');

+canvas.drawFocusIfNeeded(document.getElementById("button1"));

canvas.beginPath();

canvas.rect(50, 200, 200, 100);

canvas.fillStyle = "#cfc";

canvas.fill();

-canvas.drawSystemFocusRing(document.getElementById("button2"));

+canvas.drawFocusIfNeeded(document.getElementById("button2"));

// The top rect"s focus ring is tied to button1, which is focused.

// It should have an outline in some color other than the background color.

« no previous file with comments | « no previous file | LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt » ('j') | no next file with comments »