LayoutTests/fast/canvas/draw-system-focus-ring.html - Issue 208003003: Rename drawSystemFocusRing() to drawFocusIfNeeded()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/canvas/draw-system-focus-ring.html

Issue 208003003: Rename drawSystemFocusRing() to drawFocusIfNeeded() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/canvas/draw-focus-if-needed-on-event-expected.txt ('k') | LayoutTests/fast/canvas/draw-system-focus-ring-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE HTML>

2 <head>

3 <title>Canvas test: drawSystemFocusRing</title>

4 <script src="../../resources/js-test.js"></script>

5 </head>

6 <body style="padding: 0; margin: 0">

7 <canvas id="canvas" class="output" width="300" height="350">

8 <button id="button1"></button>

9 <button id="button2"></button>

10 </canvas>

11 <script>

12 if (window.testRunner)

13 testRunner.dumpAsText();

14

15 document.getElementById("button1").focus();

16

17 var canvas = document.getElementById("canvas").getContext("2d");

18

19 shouldNotThrow('canvas.drawSystemFocusRing(null);');

20 shouldThrow('canvas.drawSystemFocusRing();');

21

22 canvas.beginPath();

23 canvas.rect(50, 50, 200, 100);

24 canvas.fillStyle = "#ccf";

25 canvas.fill();

26 // re-test null case after having defined a path (regression test for crbug.com/ 353248)

27 shouldNotThrow('canvas.drawSystemFocusRing(null);');

28 canvas.drawSystemFocusRing(document.getElementById("button1"));

29

30 canvas.beginPath();

31 canvas.rect(50, 200, 200, 100);

32 canvas.fillStyle = "#cfc";

33 canvas.fill();

34 canvas.drawSystemFocusRing(document.getElementById("button2"));

35

36 // The top rect"s focus ring is tied to button1, which is focused.

37 // It should have an outline in some color other than the background color.

38 var imageData = canvas.getImageData(49, 50, 1, 1);

39 var data = imageData.data;

40 shouldBe("data[0] != 0 \|\| data[1] != 0 \|\| data[2] != 0", "true");

41

42 // The bottom rect"s focus ring is tied to button2, which is not focused.

43 imageData = canvas.getImageData(49, 200, 1, 1);

44 data = imageData.data;

45 shouldBe("data[0] == 0 && data[1] == 0 && data[2] == 0", "true");

46 </script>

47 </body>

OLD	NEW