Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 208003002: Reland of r20146 "JSObject::NormalizeElements() handlified." (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Reland of r20146 "JSObject::NormalizeElements() handlified." R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20161

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing review notes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -71 lines) Patch
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 1 1 chunk +40 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-21 11:10:33 UTC) #1
Toon Verwaest
https://codereview.chromium.org/208003002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4665 src/objects.cc:4665: MUST_USE_RESULT Handle<SeededNumberDictionary> CopyFastElementsToDictionary( Remove the MUST_USE_RESULT annotation.
6 years, 9 months ago (2014-03-21 12:01:15 UTC) #2
Toon Verwaest
lgtm otherwise.
6 years, 9 months ago (2014-03-21 12:01:25 UTC) #3
Toon Verwaest
https://codereview.chromium.org/208003002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4682 src/objects.cc:4682: // exceed the capacity of new space, and we ...
6 years, 9 months ago (2014-03-21 12:02:49 UTC) #4
Igor Sheludko
https://codereview.chromium.org/208003002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4665 src/objects.cc:4665: MUST_USE_RESULT Handle<SeededNumberDictionary> CopyFastElementsToDictionary( On 2014/03/21 12:01:15, Toon Verwaest wrote: ...
6 years, 9 months ago (2014-03-21 12:05:45 UTC) #5
Igor Sheludko
6 years, 9 months ago (2014-03-21 12:23:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698