[Offline pages] Adding junit tests to OfflinePageUtils

[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252
Committed: https://crrev.com/6ece9ec00175fe6a5497165f2d56a106e1e8d862
Cr-Commit-Position: refs/heads/master@{#401631}

[fgorski, 2016-06-20 17:11:48]

Description was changed from

==========
[Offline pages] Adding junit tests to OfflinePageUtils

BUG=594252
==========

to

==========
[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252
==========

[fgorski, 2016-06-20 17:11:49]

fgorski@chromium.org changed reviewers:
+ petewil@chromium.org

[fgorski, 2016-06-20 23:09:59]

PTAL

[Pete Williamson, 2016-06-20 23:45:35]

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
(right):

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:135:
// Save page not called because tab is showing an error page.
Does this comment need to be updated?  It is failing because the feature is
disabled, not just because we got an error page (though an error page may be the
symptom we see).

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:175:
// Save page not called because web contents is destroyed.
destroyed -> incognito ?

[fgorski, 2016-06-21 21:06:59]

PTAL

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
(right):

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:135:
// Save page not called because tab is showing an error page.
On 2016/06/20 23:45:35, Pete Williamson wrote:
> Does this comment need to be updated?  It is failing because the feature is
> disabled, not just because we got an error page (though an error page may be
the
> symptom we see).

Done.

https://codereview.chromium.org/2080013002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java:175:
// Save page not called because web contents is destroyed.
On 2016/06/20 23:45:35, Pete Williamson wrote:
> destroyed -> incognito ?

Done.

[Pete Williamson, 2016-06-23 16:13:48]

lgtm

[fgorski, 2016-06-23 16:17:12]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-06-23 16:17:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080013002/20001

[commit-bot: I haz the power, 2016-06-23 16:53:59]

Description was changed from

==========
[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252
==========

to

==========
[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252
==========

[commit-bot: I haz the power, 2016-06-23 16:54:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-23 16:56:58]

Description was changed from

==========
[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252
==========

to

==========
[Offline pages] Adding junit tests to OfflinePageUtils

* Takes advantage of Tab.java no longer being final
* Adds a test for OfflinePageUtils#saveBookmarkOffline

BUG=594252

Committed: https://crrev.com/6ece9ec00175fe6a5497165f2d56a106e1e8d862
Cr-Commit-Position: refs/heads/master@{#401631}
==========

[commit-bot: I haz the power, 2016-06-23 16:56:59]

Patchset 2 (id:??) landed as
https://crrev.com/6ece9ec00175fe6a5497165f2d56a106e1e8d862
Cr-Commit-Position: refs/heads/master@{#401631}