components/password_manager/content/renderer/credential_manager_client.cc - Issue 2079943002: Change RenderFrame to use InterfaceRegistry et al.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.cc

Issue 2079943002: Change RenderFrame to use InterfaceRegistry et al. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a2

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/DEPS ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | content/browser/frame_host/frame_mojo_shell.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.cc

diff --git a/components/password_manager/content/renderer/credential_manager_client.cc b/components/password_manager/content/renderer/credential_manager_client.cc

index 0f8d9689564f16feb5207b78116331d2ee08fa0f..5aa87be8726d688fcb99f407bfbf8ea310b6e496 100644

--- a/components/password_manager/content/renderer/credential_manager_client.cc

+++ b/components/password_manager/content/renderer/credential_manager_client.cc

@@ -13,9 +13,9 @@

#include "base/logging.h"

#include "components/password_manager/content/public/cpp/type_converters.h"

#include "components/password_manager/core/common/credential_manager_types.h"

-#include "content/public/common/service_registry.h"

#include "content/public/renderer/render_frame.h"

#include "content/public/renderer/render_view.h"

+#include "services/shell/public/cpp/interface_provider.h"

#include "third_party/WebKit/public/platform/WebCredential.h"

#include "third_party/WebKit/public/platform/WebCredentialManagerError.h"

#include "third_party/WebKit/public/platform/WebFederatedCredential.h"

@@ -210,8 +210,7 @@ void CredentialManagerClient::ConnectToMojoCMIfNeeded() {

return;

content::RenderFrame* main_frame = render_view()->GetMainRenderFrame();

- main_frame->GetServiceRegistry()->ConnectToRemoteService(

- mojo::GetProxy(&mojo_cm_service_));

+ main_frame->GetRemoteInterfaces()->GetInterface(&mojo_cm_service_);

}

void CredentialManagerClient::OnDestruct() {