Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chromeos/cert_loader.cc

Issue 20799002: Fix CertLoader certificates_loaded() during notification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/cert_loader.cc
diff --git a/chromeos/cert_loader.cc b/chromeos/cert_loader.cc
index ff57d36c1c2ec8a0a4e161d39bbbba38afd69091..c71d6013ec4571c022bc0cc864ec6f29ef5a5267 100644
--- a/chromeos/cert_loader.cc
+++ b/chromeos/cert_loader.cc
@@ -44,8 +44,7 @@ base::TimeDelta GetNextRequestDelayMs(base::TimeDelta last_delay) {
}
void LoadNSSCertificates(net::CertificateList* cert_list) {
- if (base::chromeos::IsRunningOnChromeOS())
- net::NSSCertDatabase::GetInstance()->ListCerts(cert_list);
+ net::NSSCertDatabase::GetInstance()->ListCerts(cert_list);
}
void CallOpenPersistentNSSDB() {
@@ -345,8 +344,8 @@ void CertLoader::UpdateCertificates(net::CertificateList* cert_list) {
// Ignore any existing certificates.
cert_list_.swap(*cert_list);
- NotifyCertificatesLoaded(!certificates_loaded_);
certificates_loaded_ = true;
+ NotifyCertificatesLoaded(certificates_loaded_);
stevenjb 2013/07/26 19:40:53 This will never call NotifyCertificatesLoaded with
pneubeck (no reviews) 2013/07/29 06:19:40 Oh. totally missed that.
certificates_update_running_ = false;
if (certificates_update_required_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698