Initial Bazel file resolver support.

Initial Bazel file resolver support.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b7aff9c72fec6ce502ba436a34f2e34d8cc14fda

[jwren, 2016-06-17 20:33:56]

Description was changed from

==========
Initial Bazel file resolver support.















BUG=
==========

to

==========
Initial Bazel file resolver support.
==========

[jwren, 2016-06-17 20:34:13]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-17 20:53:11]

lgtm

https://codereview.chromium.org/2079873002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2079873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1651:
if(context.fileResolverProvider == null) {
nit: format the code

https://codereview.chromium.org/2079873002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2079873002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:53: if (!buildDir.exists) {
Checking for existence is expensive, and there's no guarantee that 'clean' won't
be run after we check and before we access it. If the right thing to do when a
directory doesn't exist is to ignore it, then perhaps put a try-catch around
lines 57- 60:

  try {
    File file = buildDir.getChildAssumingFile(relativeFromWorkspaceDir);
    return file.createSource(actualUri ?? uri);
  } on IOException catch (exception) {
    // Ignore non-existent directories and files.
  }

The same comment applies to line 42.

[jwren, 2016-06-17 21:19:45]

https://codereview.chromium.org/2079873002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2079873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1651:
if(context.fileResolverProvider == null) {
On 2016/06/17 20:53:10, Brian Wilkerson wrote:
> nit: format the code

Done.

https://codereview.chromium.org/2079873002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2079873002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:53: if (!buildDir.exists) {
On 2016/06/17 20:53:11, Brian Wilkerson wrote:
> Checking for existence is expensive, and there's no guarantee that 'clean'
won't
> be run after we check and before we access it. If the right thing to do when a
> directory doesn't exist is to ignore it, then perhaps put a try-catch around
> lines 57- 60:
> 
>   try {
>     File file = buildDir.getChildAssumingFile(relativeFromWorkspaceDir);
>     return file.createSource(actualUri ?? uri);
>   } on IOException catch (exception) {
>     // Ignore non-existent directories and files.
>   }
> 
> The same comment applies to line 42.

Done.

[jwren, 2016-06-17 21:20:58]

Description was changed from

==========
Initial Bazel file resolver support.
==========

to

==========
Initial Bazel file resolver support.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b7aff9c72fec6ce502ba436a34f2e34d8cc14fda
==========

[jwren, 2016-06-17 21:21:00]

Committed patchset #3 (id:40001) manually as
b7aff9c72fec6ce502ba436a34f2e34d8cc14fda (presubmit successful).