chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js - Issue 2079853002: Add Edit/Create Address Dialog to MD Settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

Issue 2079853002: Add Edit/Create Address Dialog to MD Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromium_presubmit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp » ('j') | chrome/test/data/webui/settings/settings_autofill_section_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

index 4d3b0f5d9bd953f3cf909aae987316c7d2ff6b03..c9704a875e47d3c3a9cc60db462a02d8a52ef8e1 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

@@ -72,8 +72,8 @@

* @private

onAddAddressTap_: function(e) {

- // TODO(hcarmona): implement adding an address.

e.preventDefault();

+ this.$.addressEditDialog.open({});

/**

@@ -81,7 +81,8 @@

* @private

onMenuEditAddressTap_: function() {

- // TODO(hcarmona): implement editing an address.

+ var menu = this.$.addressSharedMenu;

+ this.$.addressEditDialog.open(menu.itemData);

this.$.addressSharedMenu.closeMenu();

michaelpg 2016/06/22 00:25:14 menu.

hcarmona 2016/06/24 18:27:51 Done.