chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js - Issue 2079853002: Add Edit/Create Address Dialog to MD Settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

Issue 2079853002: Add Edit/Create Address Dialog to MD Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js ('K') | « chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp » ('j') | chrome/test/data/webui/settings/settings_autofill_section_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

index 4807235331338b639f5131c48160fe078a2fcec7..2e5d8988ffb832a195460c6e610dae5220452f4a 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

@@ -75,8 +75,8 @@

* @private

onAddAddressTap_: function(e) {

- // TODO(hcarmona): implement adding an address.

e.preventDefault();

+ this.$.addressEditDialog.open({});

/**

@@ -88,9 +88,9 @@

/** @type {chrome.autofillPrivate.AddressEntry} */

var address = menu.itemData;

- // TODO(hcarmona): implement editing a local address.

- if (!address.metadata.isLocal)

+ if (address.metadata.isLocal)

+ this.$.addressEditDialog.open(address);

+ else

window.open(this.i18n('manageAddressesUrl'));

menu.closeMenu();