Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2079843005: Tear-off --fast-startup mode performance fix (Closed)

Created:
4 years, 6 months ago by sra1
Modified:
4 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tear-off --fast-startup mode performance fix Install $stubName property to enable fast tear-offs in --fast-startup mode. Without the $stubName property, the most generic path is used which is 10x slower. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/256fa69b64bb7779b37f1985dd368a34ca839662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
floitsch
LGTM.
4 years, 6 months ago (2016-06-20 18:15:39 UTC) #3
sra1
4 years, 6 months ago (2016-06-21 17:46:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
256fa69b64bb7779b37f1985dd368a34ca839662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698