Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2079843004: Revert of QUIC - minor debugging logic to see why SCT verification is failing when (Closed)

Created:
4 years, 6 months ago by ramant (doing other things)
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - minor debugging logic to see why SCT verification is failing when (patchset #2 id:20001 of https://codereview.chromium.org/1949333002/ ) Reason for revert: Reverting the Debugging code. Original issue's description: > QUIC - minor debugging logic to see why SCT verification is failing when > QUIC is accessed from home. > > Will delete this code asap. > > R=rch@chromium.org > > Committed: https://crrev.com/3903514d7dda980ff099152f69bdfb4964c6c707 > Cr-Commit-Position: refs/heads/master@{#391950} TBR=rch@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M net/quic/crypto/proof_verifier_chromium.cc View 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ramant (doing other things)
Created Revert of QUIC - minor debugging logic to see why SCT verification is failing ...
4 years, 6 months ago (2016-06-17 19:18:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079843004/1
4 years, 6 months ago (2016-06-17 19:18:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/202718)
4 years, 6 months ago (2016-06-17 19:25:36 UTC) #5
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-17 19:39:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079843004/1
4 years, 6 months ago (2016-06-17 20:21:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/202770)
4 years, 6 months ago (2016-06-17 20:29:07 UTC) #10
ramant (doing other things)
4 years, 6 months ago (2016-06-17 20:38:57 UTC) #11
Message was sent while issue was closed.
On 2016/06/17 20:29:07, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

It was already reverted. Sorry about this CL.

Powered by Google App Engine
This is Rietveld 408576698