Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/, showing enumerating audio devices in a format of (default) plus other chromeos audio devices.

Committed: https://crrev.com/86ab42900db31a6c8853b9154ae9942a001022cb
Cr-Commit-Position: refs/heads/master@{#405290}

[Qiang(Joe) Xu, 2016-06-17 22:04:46]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:05:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079843003/20001

[commit-bot: I haz the power, 2016-06-17 22:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 22:13:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Qiang(Joe) Xu, 2016-06-17 22:18:12]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:18:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079843003/40001

[commit-bot: I haz the power, 2016-06-17 22:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 22:22:28]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Qiang(Joe) Xu, 2016-06-17 22:44:51]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 22:45:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079843003/60001

[commit-bot: I haz the power, 2016-06-17 22:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 22:52:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Qiang(Joe) Xu, 2016-06-17 22:55:04]

Description was changed from

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=
TEST=add unittest in audio_manager_unittest; also checks with
navigator.mediaDevices.enumerateDevices
test doesn't include beamformingdevices case yet as I am still not quite clear
about its usage.
==========

to

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; also checks with
navigator.mediaDevices.enumerateDevices
test doesn't include beamformingdevices case yet as I am still not quite clear
about its usage.
==========

[Qiang(Joe) Xu, 2016-06-17 23:10:36]

warx@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dgreid@chromium.org, tommi@chromium.org

[Qiang(Joe) Xu, 2016-06-17 23:48:39]

+tommi for media/audio ownner review
+dgreid as audio_manager_cras related review
+dalecurtis for DEPS review, please let me know if it should be a seperate CL.

thanks

[tommi (sloooow) - chröme, 2016-06-18 14:00:37]

lgtm

https://codereview.chromium.org/2079843003/diff/60001/media/audio/audio_manag...
File media/audio/audio_manager_unittest.cc (right):

https://codereview.chromium.org/2079843003/diff/60001/media/audio/audio_manag...
media/audio/audio_manager_unittest.cc:304: ++it;
nit: move this to just above the loop. As is, it looks unrelated to the
following line.

[Qiang(Joe) Xu, 2016-07-06 16:27:02]

Updated based on tommi's comments. Dale, Dylan, could you please take a look?
thanks

https://codereview.chromium.org/2079843003/diff/60001/media/audio/audio_manag...
File media/audio/audio_manager_unittest.cc (right):

https://codereview.chromium.org/2079843003/diff/60001/media/audio/audio_manag...
media/audio/audio_manager_unittest.cc:304: ++it;
On 2016/06/18 14:00:37, tommi-chrömium wrote:
> nit: move this to just above the loop. As is, it looks unrelated to the
> following line.

Done.

[DaleCurtis, 2016-07-06 18:58:53]

lgtm

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
media/audio/cras/audio_manager_cras.cc:168:
device_names->push_back(device_name);
Does emplace_back(device.device_name, base::Uint64ToString(device.id)) work?

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
media/audio/cras/audio_manager_cras.cc:172:
device_names->push_front(media::AudioDeviceName::CreateDefault());
Just do this first to avoid push_front?

[Qiang(Joe) Xu, 2016-07-07 00:32:45]

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
media/audio/cras/audio_manager_cras.cc:168:
device_names->push_back(device_name);
On 2016/07/06 18:58:52, DaleCurtis wrote:
> Does emplace_back(device.device_name, base::Uint64ToString(device.id)) work?

done. tks.

https://codereview.chromium.org/2079843003/diff/80001/media/audio/cras/audio_...
media/audio/cras/audio_manager_cras.cc:172:
device_names->push_front(media::AudioDeviceName::CreateDefault());
On 2016/07/06 18:58:53, DaleCurtis wrote:
> Just do this first to avoid push_front?

done. tks.

[DaleCurtis, 2016-07-07 17:18:53]

lgtm

[Qiang(Joe) Xu, 2016-07-11 21:08:24]

Description was changed from

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; also checks with
navigator.mediaDevices.enumerateDevices
test doesn't include beamformingdevices case yet as I am still not quite clear
about its usage.
==========

to

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include
beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/,
showing enumerating audio devices in a format of (default) plus other chromeos
audio devices.
==========

[Qiang(Joe) Xu, 2016-07-11 21:11:04]

Update: Since chromeos audio tray view is using device.display_name:
https://cs.chromium.org/chromium/src/ash/common/system/chromeos/audio/audio_d...

A nit in audio_manager_cras is to use display_name to align with chromeos tray
label.

Dylan, could you also take a look at this? tks

[dgreid, 2016-07-13 18:45:57]

lgtm

[Qiang(Joe) Xu, 2016-07-13 18:48:41]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-07-13 18:48:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2079843003/#ps140001
(title: "nit: using display_name instead of device_name")

[commit-bot: I haz the power, 2016-07-13 18:50:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 21:28:40]

Description was changed from

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include
beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/,
showing enumerating audio devices in a format of (default) plus other chromeos
audio devices.
==========

to

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include
beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/,
showing enumerating audio devices in a format of (default) plus other chromeos
audio devices.
==========

[commit-bot: I haz the power, 2016-07-13 21:28:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-07-13 21:29:33]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 21:30:25]

Description was changed from

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include
beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/,
showing enumerating audio devices in a format of (default) plus other chromeos
audio devices.
==========

to

==========
Allow AudioManagerCras enumerate audio devices from CRAS not just defaults

BUG=605198
TEST=add unittest in audio_manager_unittest; unittest doesn't include
beamformingdevices case yet as I am still not quite clear about its usage.

tested with https://webrtc.github.io/samples/src/content/devices/input-output/,
showing enumerating audio devices in a format of (default) plus other chromeos
audio devices.

Committed: https://crrev.com/86ab42900db31a6c8853b9154ae9942a001022cb
Cr-Commit-Position: refs/heads/master@{#405290}
==========

[commit-bot: I haz the power, 2016-07-13 21:30:27]

Patchset 8 (id:??) landed as
https://crrev.com/86ab42900db31a6c8853b9154ae9942a001022cb
Cr-Commit-Position: refs/heads/master@{#405290}