Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: src/builtins.cc

Issue 2079823002: [stubs] Implementing CodeStubAssembler::GetOwnProperty(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixing TryHasOwnProperty and addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins.h" 5 #include "src/builtins.h"
6 6
7 #include "src/api-arguments.h" 7 #include "src/api-arguments.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/base/ieee754.h" 10 #include "src/base/ieee754.h"
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 Node* map = assembler->LoadMap(object); 361 Node* map = assembler->LoadMap(object);
362 Node* instance_type = assembler->LoadMapInstanceType(map); 362 Node* instance_type = assembler->LoadMapInstanceType(map);
363 363
364 Variable var_index(assembler, MachineRepresentation::kWord32); 364 Variable var_index(assembler, MachineRepresentation::kWord32);
365 365
366 Label keyisindex(assembler), if_iskeyunique(assembler); 366 Label keyisindex(assembler), if_iskeyunique(assembler);
367 assembler->TryToName(key, &keyisindex, &var_index, &if_iskeyunique, 367 assembler->TryToName(key, &keyisindex, &var_index, &if_iskeyunique,
368 &call_runtime); 368 &call_runtime);
369 369
370 assembler->Bind(&if_iskeyunique); 370 assembler->Bind(&if_iskeyunique);
371 assembler->TryLookupProperty(object, map, instance_type, key, &return_true, 371 assembler->TryHasOwnProperty(object, map, instance_type, key, &return_true,
372 &return_false, &call_runtime); 372 &return_false, &call_runtime);
373 373
374 assembler->Bind(&keyisindex); 374 assembler->Bind(&keyisindex);
375 assembler->TryLookupElement(object, map, instance_type, var_index.value(), 375 assembler->TryLookupElement(object, map, instance_type, var_index.value(),
376 &return_true, &return_false, &call_runtime); 376 &return_true, &return_false, &call_runtime);
377 377
378 assembler->Bind(&return_true); 378 assembler->Bind(&return_true);
379 assembler->Return(assembler->BooleanConstant(true)); 379 assembler->Return(assembler->BooleanConstant(true));
380 380
381 assembler->Bind(&return_false); 381 assembler->Bind(&return_false);
(...skipping 5647 matching lines...) Expand 10 before | Expand all | Expand 10 after
6029 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 6029 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
6030 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 6030 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
6031 #undef DEFINE_BUILTIN_ACCESSOR_C 6031 #undef DEFINE_BUILTIN_ACCESSOR_C
6032 #undef DEFINE_BUILTIN_ACCESSOR_A 6032 #undef DEFINE_BUILTIN_ACCESSOR_A
6033 #undef DEFINE_BUILTIN_ACCESSOR_T 6033 #undef DEFINE_BUILTIN_ACCESSOR_T
6034 #undef DEFINE_BUILTIN_ACCESSOR_S 6034 #undef DEFINE_BUILTIN_ACCESSOR_S
6035 #undef DEFINE_BUILTIN_ACCESSOR_H 6035 #undef DEFINE_BUILTIN_ACCESSOR_H
6036 6036
6037 } // namespace internal 6037 } // namespace internal
6038 } // namespace v8 6038 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/code-stub-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698