Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2079783002: Move HSTS redirection from URLRequest to URLRequestHTTPJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index f9d197c6319eb23a7f7e7f0e0188bdbc53465c7f..91bca58a540aa93d06740975f2231364dfe944b4 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -8653,26 +8653,6 @@ TEST_F(HTTPSRequestTest, HSTSCrossOriginAddHeaders) {
EXPECT_EQ(kOriginHeaderValue, received_cors_header);
}
-// This just tests the behaviour of GetHSTSRedirect(). End-to-end tests of HSTS
-// are performed in net/websockets/websocket_end_to_end_test.cc.
-TEST(WebSocketURLRequestTest, HSTSApplied) {
- TestNetworkDelegate network_delegate;
- TransportSecurityState transport_security_state;
- base::Time expiry = base::Time::Now() + base::TimeDelta::FromDays(1);
- bool include_subdomains = false;
- transport_security_state.AddHSTS("example.net", expiry, include_subdomains);
- TestURLRequestContext context(true);
- context.set_transport_security_state(&transport_security_state);
- context.set_network_delegate(&network_delegate);
- context.Init();
- GURL ws_url("ws://example.net/echo");
- TestDelegate delegate;
- std::unique_ptr<URLRequest> request(
- context.CreateRequest(ws_url, DEFAULT_PRIORITY, &delegate));
- EXPECT_TRUE(request->GetHSTSRedirect(&ws_url));
- EXPECT_TRUE(ws_url.SchemeIs("wss"));
-}
-
namespace {
class SSLClientAuthTestDelegate : public TestDelegate {

Powered by Google App Engine
This is Rietveld 408576698