Move HSTS redirection from URLRequest to URLRequestHTTPJob.

net/url_request/url_request_http_job_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include <stdint.h>
 
 #include <cstddef>
 #include <memory>
 
 #include "base/compiler_specific.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/strings/string_split.h"
 #include "net/base/auth.h"
 #include "net/base/request_priority.h"
 #include "net/base/sdch_observer.h"
 #include "net/base/test_data_directory.h"
 #include "net/cookies/cookie_store_test_helpers.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/http/http_transaction_test_util.h"
+#include "net/log/test_net_log.h"
+#include "net/log/test_net_log_entry.h"
+#include "net/log/test_net_log_util.h"
 #include "net/socket/socket_test_util.h"
 #include "net/test/cert_test_util.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "net/url_request/url_request_status.h"
 #include "net/url_request/url_request_test_util.h"
 #include "net/websockets/websocket_handshake_stream_base.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 584 matching lines @@
 // Confirm we don't advertise SDCH encoding in the case of a POST.
 TEST_F(URLRequestHttpJobTest, SdchAdvertisementPost) {
   EnableSdch();
   req_->set_method("POST");
   test_job_interceptor_->set_main_intercept_job(
       base::WrapUnique(new TestURLRequestHttpJob(req_.get())));
   req_->Start();
   EXPECT_FALSE(TransactionAcceptsSdchEncoding());
 }
 
+TEST_F(URLRequestHttpJobTest, HSTSInternalRedirectTest) {
+  // Setup HSTS state.
+  context_.transport_security_state()->AddHSTS(
+      "upgrade.test", base::Time::Now() + base::TimeDelta::FromSeconds(10),
+      true);
+  ASSERT_TRUE(
+      context_.transport_security_state()->ShouldUpgradeToSSL("upgrade.test"));
+  ASSERT_FALSE(context_.transport_security_state()->ShouldUpgradeToSSL(
+      "no-upgrade.test"));
+
+  net::TestNetLog net_log;
+  context_.set_net_log(&net_log);

[mmenke, 2016/06/17 15:06:18]

Could you move this into the test fixture, just before the context is
initialized and add an accessor?  It's weird to set this on a
TestURLRequestContext that's already been initialized, though it doesn't
actually matter for these tests.  A number of URLRequestContext objects have
pointers to the NetLog, and that makes sure they're all set consistently.

[Mike West, 2016/06/17 16:35:17]

Sure! Done.

+
+  struct TestCase {
+    const char* url;
+    bool upgrade_expected;
+    const char* url_expected;
+  } cases[] = {
+      {"http://upgrade.test/", true, "https://upgrade.test/"},
+      {"ws://upgrade.test/", true, "wss://upgrade.test/"},
+      {"http://upgrade.test:123/", true, "https://upgrade.test:123/"},
+      {"ws://upgrade.test:123/", true, "wss://upgrade.test:123/"},
+      {"http://no-upgrade.test/", false, "http://no-upgrade.test/"},
+      {"ws://no-upgrade.test/", false, "ws://no-upgrade.test/"},
+      {"http://no-upgrade.test:123/", false, "http://no-upgrade.test:123/"},
+      {"ws://no-upgrade.test:123/", false, "ws://no-upgrade.test:123/"},

[mmenke, 2016/06/17 15:06:18]

Hrm...Websocket requests generally aren't made through URLRequest directly, but
through a wrapper...which does use URLRequest, so I think this is fine.

However, I don't think that wrapper actually allows websocket requests to be
redirected.  Not relevant for this CL, but thinking you may run into issues
there on your other CL.

[Mike West, 2016/06/17 16:35:17]

I look forward to exploring the crazy in the other CL. ;)

+  };
+
+  for (const auto& test : cases) {
+    SCOPED_TRACE(test.url);
+    TestDelegate d;
+    TestNetworkDelegate network_delegate;
+    std::unique_ptr<URLRequest> r(
+        context_.CreateRequest(GURL(test.url), DEFAULT_PRIORITY, &d));
+    std::unique_ptr<URLRequestJob> job(URLRequestHttpJob::Factory(
+        r.get(), &network_delegate, url::kHttpScheme));

[mmenke, 2016/06/17 15:06:18]

This object isn't being used anywhere, please delete it.

[Mike West, 2016/06/17 16:35:17]

Done.

+
+    net_log.Clear();
+    r->Start();
+    base::RunLoop().Run();
+
+    if (test.upgrade_expected) {
+      net::TestNetLogEntry::List entries;
+      net_log.GetEntries(&entries);
+      int redirects = 0;
+      for (const auto& entry : entries) {
+        if (entry.type == net::NetLog::TYPE_URL_REQUEST_REDIRECT_JOB) {
+          redirects++;
+          std::string value;
+          EXPECT_TRUE(entry.GetStringValue("reason", &value));
+          EXPECT_EQ("HSTS", value);
+        }
+      }
+      EXPECT_EQ(1, redirects);
+      EXPECT_EQ(1, d.received_redirect_count());

[mmenke, 2016/06/17 15:06:18]

Suggest checking r->url_chain()'s length as well, here, and below - it's
redundant, but it's the main URLRequest API, so seems more important.

[Mike West, 2016/06/17 16:35:17]

Added.

+    } else {
+      EXPECT_EQ(0, d.received_redirect_count());
+    }
+    EXPECT_EQ(GURL(test.url_expected), r->url());
+  }
+}
+
 class MockSdchObserver : public SdchObserver {
  public:
   MockSdchObserver() {}
   MOCK_METHOD2(OnDictionaryAdded,
                void(const GURL& request_url, const std::string& server_hash));
   MOCK_METHOD1(OnDictionaryRemoved, void(const std::string& server_hash));
   MOCK_METHOD1(OnDictionaryUsed, void(const std::string& server_hash));
   MOCK_METHOD2(OnGetDictionary,
                void(const GURL& request_url, const GURL& dictionary_url));
   MOCK_METHOD0(OnClearDictionaries, void());
@@ skipping 299 matching lines @@
                     create_helper.release());
   req_->SetLoadFlags(LOAD_DISABLE_CACHE);
   req_->Start();
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(URLRequestStatus::IO_PENDING, req_->status().status());
   EXPECT_TRUE(fake_handshake_stream->initialize_stream_was_called());
 }
 
 #endif  // !defined(OS_IOS)
 
+class URLRequestHttpJobInternalRedirectTest : public ::testing::Test {
+ protected:
+  URLRequestHttpJobInternalRedirectTest()
+      : context_(new TestURLRequestContext(true)) {
+    std::unique_ptr<HttpNetworkSession::Params> params(
+        new HttpNetworkSession::Params);
+    context_->set_enable_brotli(true);
+    context_->set_http_network_session_params(std::move(params));
+    context_->set_client_socket_factory(&socket_factory_);
+    context_->Init();
+  }
+
+  MockClientSocketFactory socket_factory_;
+  std::unique_ptr<TestURLRequestContext> context_;
+};
+
 }  // namespace
 
 }  // namespace net