Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: net/url_request/url_request_http_job.h

Issue 2079783002: Move HSTS redirection from URLRequest to URLRequestHTTPJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 22 matching lines...) Expand all
33 33
34 class HttpRequestHeaders; 34 class HttpRequestHeaders;
35 class HttpResponseHeaders; 35 class HttpResponseHeaders;
36 class HttpResponseInfo; 36 class HttpResponseInfo;
37 class HttpTransaction; 37 class HttpTransaction;
38 class HttpUserAgentSettings; 38 class HttpUserAgentSettings;
39 class ProxyInfo; 39 class ProxyInfo;
40 class SSLPrivateKey; 40 class SSLPrivateKey;
41 class UploadDataStream; 41 class UploadDataStream;
42 class URLRequestContext; 42 class URLRequestContext;
43 class URLRequestRedirectJob;
mmenke 2016/06/17 15:08:07 Rather not forward declare this - can either make
Mike West 2016/06/17 16:35:16 Done.
43 44
44 // A URLRequestJob subclass that is built on top of HttpTransaction. It 45 // A URLRequestJob subclass that is built on top of HttpTransaction. It
45 // provides an implementation for both HTTP and HTTPS. 46 // provides an implementation for both HTTP and HTTPS.
46 class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob { 47 class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
47 public: 48 public:
48 static URLRequestJob* Factory(URLRequest* request, 49 static URLRequestJob* Factory(URLRequest* request,
49 NetworkDelegate* network_delegate, 50 NetworkDelegate* network_delegate,
50 const std::string& scheme); 51 const std::string& scheme);
51 52
52 protected: 53 protected:
53 URLRequestHttpJob(URLRequest* request, 54 URLRequestHttpJob(URLRequest* request,
54 NetworkDelegate* network_delegate, 55 NetworkDelegate* network_delegate,
55 const HttpUserAgentSettings* http_user_agent_settings); 56 const HttpUserAgentSettings* http_user_agent_settings);
56 57
57 ~URLRequestHttpJob() override; 58 ~URLRequestHttpJob() override;
58 59
60 static URLRequestRedirectJob* MaybeInternallyRedirect(
61 URLRequest* request,
62 NetworkDelegate* network_delegate);
mmenke 2016/06/17 15:08:07 Actually, if this is static, can we just move it i
Mike West 2016/06/17 16:35:17 Done.
63
59 // Overridden from URLRequestJob: 64 // Overridden from URLRequestJob:
60 void SetPriority(RequestPriority priority) override; 65 void SetPriority(RequestPriority priority) override;
61 void Start() override; 66 void Start() override;
62 void Kill() override; 67 void Kill() override;
63 void GetConnectionAttempts(ConnectionAttempts* out) const override; 68 void GetConnectionAttempts(ConnectionAttempts* out) const override;
64 69
65 RequestPriority priority() const { 70 RequestPriority priority() const {
66 return priority_; 71 return priority_;
67 } 72 }
68 73
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 int64_t total_sent_bytes_from_previous_transactions_; 284 int64_t total_sent_bytes_from_previous_transactions_;
280 285
281 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_; 286 base::WeakPtrFactory<URLRequestHttpJob> weak_factory_;
282 287
283 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob); 288 DISALLOW_COPY_AND_ASSIGN(URLRequestHttpJob);
284 }; 289 };
285 290
286 } // namespace net 291 } // namespace net
287 292
288 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_ 293 #endif // NET_URL_REQUEST_URL_REQUEST_HTTP_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698