[Findit] Add a Rietveld client to post a message to codereview of a culprit.

[Findit] Add a Rietveld client to post a message to codereview of a culprit.

BUG=621140
Committed: https://chromium.googlesource.com/infra/infra/+/361d863a8737d14229b14ef051cbf40f0302f874

[stgao, 2016-06-17 18:09:42]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-06-17 18:09:42]

ptal

[stgao, 2016-06-21 15:14:15]

Chan, Jeff, ping :)

[lijeffrey, 2016-06-21 17:42:52]

lgtm

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
File appengine/findit/common/http_client_appengine.py (right):

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
appengine/findit/common/http_client_appengine.py:14: #TODO(katesonia): Move this
to config.
nit: add a space after # to keep pylint from complaining

[chanli, 2016-06-21 21:38:01]

On 2016/06/21 17:42:52, lijeffrey wrote:
> lgtm
> 
>
https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
> File appengine/findit/common/http_client_appengine.py (right):
> 
>
https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
> appengine/findit/common/http_client_appengine.py:14: #TODO(katesonia): Move
this
> to config.
> nit: add a space after # to keep pylint from complaining

lgtm

[chanli, 2016-06-21 21:38:12]

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/rie...
File appengine/findit/common/rietveld.py (right):

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/rie...
appengine/findit/common/rietveld.py:45: rietveld_url = 'https://%s' % u.netloc 
# Enforce https.
nit: Enforces?

[stgao, 2016-06-24 04:24:52]

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
File appengine/findit/common/http_client_appengine.py (right):

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/htt...
appengine/findit/common/http_client_appengine.py:14: #TODO(katesonia): Move this
to config.
On 2016/06/21 17:42:52, lijeffrey wrote:
> nit: add a space after # to keep pylint from complaining

Done.

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/rie...
File appengine/findit/common/rietveld.py (right):

https://codereview.chromium.org/2079773004/diff/1/appengine/findit/common/rie...
appengine/findit/common/rietveld.py:45: rietveld_url = 'https://%s' % u.netloc 
# Enforce https.
On 2016/06/21 21:38:11, chanli wrote:
> nit: Enforces?

Done.

[stgao, 2016-06-24 04:25:00]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-06-24 04:25:01]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2079773004/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-06-24 04:25:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079773004/20001

[stgao, 2016-06-24 04:36:55]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-06-24 04:36:56]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2079773004/#ps40001
(title: "Fix unittests.")

[commit-bot: I haz the power, 2016-06-24 04:37:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079773004/40001

[commit-bot: I haz the power, 2016-06-24 04:49:39]

Description was changed from

==========
[Findit] Add a Rietveld client to post a message to codereview of a culprit.

BUG=621140
==========

to

==========
[Findit] Add a Rietveld client to post a message to codereview of a culprit.

BUG=621140

Committed:
https://chromium.googlesource.com/infra/infra/+/361d863a8737d14229b14ef051cbf...
==========

[commit-bot: I haz the power, 2016-06-24 04:49:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/361d863a8737d14229b14ef051cbf...