src/IceInstrumentation.cpp - Issue 2079723002: Instrumented malloc and free with dummy functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstrumentation.cpp

Issue 2079723002: Instrumented malloc and free with dummy functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleaned up instrumentCall() Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstrumentation.cpp

diff --git a/src/IceInstrumentation.cpp b/src/IceInstrumentation.cpp

index fc2a4a5431f454b2cc77fdba28e6fd1b05ad59ec..cfd243a8fc7d5eb23b31db5cd065bee80c74344a 100644

--- a/src/IceInstrumentation.cpp

+++ b/src/IceInstrumentation.cpp

@@ -29,6 +29,9 @@ void Instrumentation::instrumentFunc(Cfg *Func) {

assert(Func);

assert(!Func->getNodes().empty());

+ // TODO(tlively): More selectively instrument functions so that shadow memory

+ // represents user accessibility more and library accessibility less.

+ std::string FuncName = Func->getFunctionName().toStringOrEmpty();

LoweringContext Context;

Context.init(Func->getNodes().front());

instrumentFuncStart(Context);

@@ -42,7 +45,7 @@ void Instrumentation::instrumentFunc(Cfg *Func) {

}

- if (Func->getFunctionName().toStringOrEmpty() == "_start")

+ if (FuncName == "_start")

Karl 2016/06/17 22:04:11 Move declaration of FuncName here.

tlively 2016/06/17 23:03:58 Done.

instrumentStart(Func);

}

« docs/ASAN.rst ('K') | « src/IceInstrumentation.h ('k') | tests_lit/asan_tests/instrumentmalloc.ll » ('j') | no next file with comments »