Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2079673002: Fix a regex in javac.py. (Closed)

Created:
4 years, 6 months ago by Sam McNally
Modified:
4 years, 6 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regex in javac.py. javac.py uses a regex to strip the parts after the base filename, e.g. Foo.class or Foo$Bar.class should produce Foo. However, it fails to strip .class from file names without a $. This corrects the regex. BUG=619752 Committed: https://crrev.com/14af73781b9d5372e205b01356004015c2b005ec Cr-Commit-Position: refs/heads/master@{#401177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/javac.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam McNally
4 years, 6 months ago (2016-06-20 01:35:20 UTC) #3
mikecase (-- gone --)
lgtm
4 years, 6 months ago (2016-06-21 23:02:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079673002/20001
4 years, 6 months ago (2016-06-21 23:29:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-22 02:43:52 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:46:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14af73781b9d5372e205b01356004015c2b005ec
Cr-Commit-Position: refs/heads/master@{#401177}

Powered by Google App Engine
This is Rietveld 408576698