Create only one ContextFactory in content unit tests

Create only one ContextFactory in content unit tests

ImageTransportFactory::InitializeForUnitTests gets called in the setup
of many tests.  However, ui::InitializeContextFactoryForTests via
RenderViewHostTestHarness::SetUp was also being called indirectly in
many unit tests as well.  This would result in two context factories,
one set on ui::aura::Env and the other being the ImageTransportFactory
instance.

Fix this problem by consolidating these two in content unittests.

This fix is in the service of fixing racy RenderWidgetHostViewChildFrame
tests that were using fake surface namespace ids that were never
registered.  That bug is fixed by registering that id with the (single)
global SurfaceManager on the context factory.

BUG=616976
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d31c7828f22b988a63718fd9dd8735c7220aba57
Cr-Commit-Position: refs/heads/master@{#400814}

[enne (OOO), 2016-06-16 23:11:05]

Description was changed from

==========
Create only one ContextFactory in content unit tests

ImageTransportFactory::InitializeForUnitTests gets called in the setup
of many tests.  However, ui::InitializeContextFactoryForTests via
RenderViewHostTestHarness::SetUp was also being called indirectly in
many unit tests as well.  This would result in two context factories,
one set on ui::aura::Env and the other being the ImageTransportFactory
instance.

Fix this problem by consolidating these two in content unittests.

This fix is in the service of fixing racy RenderWidgetHostViewChildFrame
tests that were using fake surface namespace ids that were never
registered.  That bug is fixed by registering that id with the (single)
global SurfaceManager on the context factory.

BUG=616976
==========

to

==========
Create only one ContextFactory in content unit tests

ImageTransportFactory::InitializeForUnitTests gets called in the setup
of many tests.  However, ui::InitializeContextFactoryForTests via
RenderViewHostTestHarness::SetUp was also being called indirectly in
many unit tests as well.  This would result in two context factories,
one set on ui::aura::Env and the other being the ImageTransportFactory
instance.

Fix this problem by consolidating these two in content unittests.

This fix is in the service of fixing racy RenderWidgetHostViewChildFrame
tests that were using fake surface namespace ids that were never
registered.  That bug is fixed by registering that id with the (single)
global SurfaceManager on the context factory.

BUG=616976
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[enne (OOO), 2016-06-16 23:11:57]

enne@chromium.org changed reviewers:
+ sievers@chromium.org

[enne (OOO), 2016-06-16 23:12:10]

ImageTransportFactory vs ContextFactory strikes again T_T

[enne (OOO), 2016-06-20 20:13:34]

enne@chromium.org changed reviewers:
+ piman@chromium.org

[enne (OOO), 2016-06-20 20:14:26]

+piman as alternate content reviewer

[piman, 2016-06-20 20:40:28]

https://codereview.chromium.org/2079623002/diff/60001/content/test/test_rende...
File content/test/test_render_view_host.cc (right):

https://codereview.chromium.org/2079623002/diff/60001/content/test/test_rende...
content/test/test_render_view_host.cc:216: // ImageTransportFactory.
nit: add DCHECK(surface_id_allocator_);

[piman, 2016-06-20 20:40:35]

lgtm

[enne (OOO), 2016-06-20 20:58:41]

https://codereview.chromium.org/2079623002/diff/60001/content/test/test_rende...
File content/test/test_render_view_host.cc (right):

https://codereview.chromium.org/2079623002/diff/60001/content/test/test_rende...
content/test/test_render_view_host.cc:216: // ImageTransportFactory.
On 2016/06/20 at 20:40:27, piman wrote:
> nit: add DCHECK(surface_id_allocator_);

Done.

[enne (OOO), 2016-06-20 20:59:20]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-06-20 20:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2079623002/#ps80001
(title: "Add dcheck")

[commit-bot: I haz the power, 2016-06-20 20:59:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079623002/80001

[commit-bot: I haz the power, 2016-06-20 22:38:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-20 22:41:35]

Description was changed from

==========
Create only one ContextFactory in content unit tests

ImageTransportFactory::InitializeForUnitTests gets called in the setup
of many tests.  However, ui::InitializeContextFactoryForTests via
RenderViewHostTestHarness::SetUp was also being called indirectly in
many unit tests as well.  This would result in two context factories,
one set on ui::aura::Env and the other being the ImageTransportFactory
instance.

Fix this problem by consolidating these two in content unittests.

This fix is in the service of fixing racy RenderWidgetHostViewChildFrame
tests that were using fake surface namespace ids that were never
registered.  That bug is fixed by registering that id with the (single)
global SurfaceManager on the context factory.

BUG=616976
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Create only one ContextFactory in content unit tests

ImageTransportFactory::InitializeForUnitTests gets called in the setup
of many tests.  However, ui::InitializeContextFactoryForTests via
RenderViewHostTestHarness::SetUp was also being called indirectly in
many unit tests as well.  This would result in two context factories,
one set on ui::aura::Env and the other being the ImageTransportFactory
instance.

Fix this problem by consolidating these two in content unittests.

This fix is in the service of fixing racy RenderWidgetHostViewChildFrame
tests that were using fake surface namespace ids that were never
registered.  That bug is fixed by registering that id with the (single)
global SurfaceManager on the context factory.

BUG=616976
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/d31c7828f22b988a63718fd9dd8735c7220aba57
Cr-Commit-Position: refs/heads/master@{#400814}
==========

[commit-bot: I haz the power, 2016-06-20 22:41:36]

Patchset 5 (id:??) landed as
https://crrev.com/d31c7828f22b988a63718fd9dd8735c7220aba57
Cr-Commit-Position: refs/heads/master@{#400814}