src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2079613003: [generators] Implement %GeneratorGetSourcePosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2079613003: [generators] Implement %GeneratorGetSourcePosition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rename again, and move subtraction to runtime Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 672a98349e18173f57ba98a794c13f3d40cb08c3..a37e12c73d56a4830138938d68e917f2b3e258e7 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1744,7 +1744,7 @@ void FullCodeGenerator::VisitYield(Yield* expr) {

// When we arrive here, eax holds the generator object.

__ RecordGeneratorContinuation();

__ mov(ebx, FieldOperand(eax, JSGeneratorObject::kResumeModeOffset));

- __ mov(eax, FieldOperand(eax, JSGeneratorObject::kInputOffset));

+ __ mov(eax, FieldOperand(eax, JSGeneratorObject::kInputOrDebugPosOffset));

STATIC_ASSERT(JSGeneratorObject::kNext < JSGeneratorObject::kReturn);

STATIC_ASSERT(JSGeneratorObject::kThrow > JSGeneratorObject::kReturn);

__ cmp(ebx, Immediate(Smi::FromInt(JSGeneratorObject::kReturn)));