chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java - Issue 2079613002: Revamping -keeps for @annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java

Issue 2079613002: Revamping -keeps for @annotations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing how we keep fragments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/proguard.flags ('K') | « chrome/android/java/proguard.flags ('k') | chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java

index 47f49ddf1a578f1fdc718544d3bcdf50b29cc263..f1d8a963a430f7a47363e7160b0bba29643d8294 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppDetailsDelegate.java

@@ -9,6 +9,7 @@ import org.chromium.base.VisibleForTesting;

/**

* Fetches data about the given app.

+@VisibleForTesting

gone 2016/06/22 17:14:45 This isn't the right annotation for this. AppDeta

smaier 2016/06/22 17:25:16 Upstream, this class is only used constructed in t

gone 2016/06/22 17:43:40 Huh. Completely forgot that this was even used up

public abstract class AppDetailsDelegate {

/**

* Class to inform when the app's details have been retrieved.