Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2079603002: Handle nested theads correctly when paginated (Closed)

Created:
4 years, 6 months ago by rhogan
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle nested theads correctly when paginated When paginated, repeat nested theads at the top of each page - replicating the way they look on the first page bar any spacing between them applied by content. We don't try to replicate any cell padding in the nested repeating theads, that would be a lot of work for not much gain. BUG=620456 Committed: https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e Cr-Commit-Position: refs/heads/master@{#402943}

Patch Set 1 #

Patch Set 2 : bug 620456 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead.html View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-2.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-2-expected.html View 1 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-3.html View 1 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-3-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-4.html View 1 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-4-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/single-line-cells-nested-repeating-thead-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 3 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rhogan
4 years, 5 months ago (2016-06-29 20:19:52 UTC) #3
eae
LGTM, I like the test!
4 years, 5 months ago (2016-06-29 20:22:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2079603002/20001
4 years, 5 months ago (2016-06-29 20:23:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:10:42 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:12:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23cfc9840611a905a979be77cf6cee31519c542e
Cr-Commit-Position: refs/heads/master@{#402943}

Powered by Google App Engine
This is Rietveld 408576698