Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2079563002: Revert of Use platform.processor to figure out if we're in a VM. (Closed)

Created:
4 years, 6 months ago by achuithb
Modified:
4 years, 6 months ago
Reviewers:
jdufault
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Use platform.processor to figure out if we're in a VM. (patchset #2 id:20001 of https://codereview.chromium.org/2068063002/ ) Reason for revert: crbug.com/620798, looks like the wrong platform is being imported Original issue's description: > Use platform.processor to figure out if we're in a VM. > > BUG=chromium:609001 > TEST=testScreenshotWithPrefix > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91122c7ad6ee5366777f1aa221fd6140f7ceabc7 TBR=jdufault@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609001 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/727456b86fb3d5e4dfd7c3851f2168c4a9de77ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M telemetry/telemetry/core/cros_interface.py View 2 chunks +5 lines, -3 lines 0 comments Download
M telemetry/telemetry/internal/platform/cros_platform_backend.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
achuithb
Created Revert of Use platform.processor to figure out if we're in a VM.
4 years, 6 months ago (2016-06-16 21:30:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079563002/1
4 years, 6 months ago (2016-06-16 21:30:13 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 21:52:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698