Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2079553002: RTC Video Encoder: implement timestamp fallback (Closed)

Created:
4 years, 6 months ago by shenghao1
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RTC Video Encoder: implement timestamp fallback BUG=620565

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M content/renderer/media/rtc_video_encoder.cc View 1 chunk +12 lines, -7 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
wuchengli
https://codereview.chromium.org/2079553002/diff/1/content/renderer/media/rtc_video_encoder.cc File content/renderer/media/rtc_video_encoder.cc (right): https://codereview.chromium.org/2079553002/diff/1/content/renderer/media/rtc_video_encoder.cc#newcode575 content/renderer/media/rtc_video_encoder.cc:575: base::TimeDelta::FromMilliseconds(next_frame->ntp_time_ms())); maybe because this line should also be reverted?
4 years, 6 months ago (2016-06-17 03:50:51 UTC) #2
Pawel Osciak
Please add a TEST= line describing how this change was tested. Thanks.
4 years, 6 months ago (2016-06-17 03:56:46 UTC) #4
wuchengli
4 years, 6 months ago (2016-06-17 05:02:03 UTC) #5 
Or maybe you need https://codereview.chromium.org/2069923005/ for nyan to work.

Powered by Google App Engine
This is Rietveld 408576698