Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2079493002: Remove unused XFA_GetElementChildren. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused XFA_GetElementChildren. This CL removes the method and the backing data. Committed: https://pdfium.googlesource.com/pdfium/+/2f284d531f08136f3a42ca26ac2c128ea8d8d2ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -298 lines) Patch
M xfa/fxfa/include/fxfa_basic.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 12 chunks +12 lines, -289 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-16 19:20:51 UTC) #3
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-16 20:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079493002/1
4 years, 6 months ago (2016-06-16 20:19:10 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:19:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/2f284d531f08136f3a42ca26ac2c128ea8d8...

Powered by Google App Engine
This is Rietveld 408576698