Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 2079423002: Remove calls to MessageLoop::current() in ios. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in ios. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=droger@chromium.org Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 Cr-Commit-Position: refs/heads/master@{#401027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ios/crnet/crnet_environment.mm View 6 chunks +6 lines, -8 lines 0 comments Download
M ios/web/web_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-21 17:22:59 UTC) #2
sdefresne
On 2016/06/21 17:22:59, fdoray wrote: > Can you review this CL? Thanks. lgtm We may ...
4 years, 6 months ago (2016-06-21 17:27:39 UTC) #3
fdoray
On 2016/06/21 17:27:39, sdefresne wrote: > On 2016/06/21 17:22:59, fdoray wrote: > > Can you ...
4 years, 6 months ago (2016-06-21 17:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079423002/1
4 years, 6 months ago (2016-06-21 17:30:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 17:36:08 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 Cr-Commit-Position: refs/heads/master@{#401027}
4 years, 6 months ago (2016-06-21 17:49:47 UTC) #9
fdoray
4 years, 3 months ago (2016-09-09 14:00:47 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2326053002/ by fdoray@chromium.org.

The reason for reverting is: This causes crashes during browser startup..

Powered by Google App Engine
This is Rietveld 408576698