crypto/signature_creator_nss.cc - Issue 20794003: Fix a bug where packing an extension with bad private key causes crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/signature_creator_nss.cc

Issue 20794003: Fix a bug where packing an extension with bad private key causes crash. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Slight wording change to the pack_extension_unittest. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/signature_creator_nss.cc

diff --git a/crypto/signature_creator_nss.cc b/crypto/signature_creator_nss.cc

index 6c21efe25fef8eb710e7c5852dcd8835124b2b69..5a9ad2e3333035462a8dd853faa28dd231208008 100644

--- a/crypto/signature_creator_nss.cc

+++ b/crypto/signature_creator_nss.cc

@@ -84,7 +84,6 @@ bool SignatureCreator::Final(std::vector<uint8>* signature) {

SECItem signature_item;

SECStatus rv = SGN_End(sign_context_, &signature_item);

if (rv != SECSuccess) {

- NOTREACHED();

return false;

}

signature->assign(signature_item.data,

« no previous file with comments | « chrome/test/data/extensions/bad_private_key/manifest.json ('k') | no next file » | no next file with comments »