Fix a bug where packing an extension with bad private key causes crash.

chrome/browser/extensions/pack_extension_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
@@ skipping 20 matching lines @@
   bool TestPackExtension(const base::FilePath& path) {
     base::ScopedTempDir temp_dir;
     EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
     EXPECT_TRUE(base::CopyDirectory(path, temp_dir.path(), true));
     CommandLine command_line(CommandLine::NO_PROGRAM);
     command_line.AppendSwitchPath(switches::kPackExtension,
                                   temp_dir.path().Append(path.BaseName()));
     return startup_helper_.PackExtension(command_line);
   }
 
+  bool TestPackExtensionKey(const base::FilePath& path,
+                            const base::FilePath& key_path) {
+    base::ScopedTempDir temp_dir;
+    EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
+    EXPECT_TRUE(base::CopyDirectory(path, temp_dir.path(), true));
+    CommandLine command_line(CommandLine::NO_PROGRAM);
+    command_line.AppendSwitchPath(switches::kPackExtension,
+                                  temp_dir.path().Append(path.BaseName()));
+    command_line.AppendSwitchPath(switches::kPackExtensionKey,
+                                  temp_dir.path().Append(key_path.BaseName()));
+    return startup_helper_.PackExtension(command_line);
+  }
+
   base::MessageLoop message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
 
   base::FilePath test_data_dir_;
   StartupHelper startup_helper_;
 };
 
 TEST_F(PackExtensionTest, Extension) {
   ASSERT_TRUE(TestPackExtension(test_data_dir_.AppendASCII("api_test")
                                               .AppendASCII("tabs")
                                               .AppendASCII("basics")));
 }
 
 TEST_F(PackExtensionTest, PackagedApp) {
   ASSERT_TRUE(TestPackExtension(test_data_dir_.AppendASCII("packaged_app")));
 }
 
 TEST_F(PackExtensionTest, PlatformApp) {
   ASSERT_TRUE(TestPackExtension(test_data_dir_.AppendASCII("platform_apps")
                                               .AppendASCII("minimal")));
 }
 
+TEST_F(PackExtensionTest, ExtensionWithInvalidKey) {

[zhchbin, 2013/07/27 00:33:24]

Why don't you put this code to the ExtensionServiceTest.PackExtension like my
patch, it will be the right place I think. And the place here has some comment:
"Tests the environment for packing extensions from the command line via the
--pack-extension switch."

Sorry for If I make a mistake here.

+  ASSERT_FALSE(TestPackExtensionKey(test_data_dir_.
+                                        AppendASCII("bad_private_key"),
+                                    test_data_dir_.
+                                        AppendASCII("bad_private_key.pem")));
+}
+
 }  // namespace extensions