[builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime

[builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime

With the tail call, pointers to the JS heap could be pushed on a
js-to-wasm frame. On the js-to-wasm frame, however, this pointer would
not be updated by the GC.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com
BUG=617084
TEST=mjsunit/wasm/gc-frame.js:GCInJSToWasmTest()

Committed: https://crrev.com/b5c69cbf39192b7efc12ae40406c8bd55a44419b
Cr-Commit-Position: refs/heads/master@{#37132}

[jbramley, 2016-06-21 08:31:49]

jacob.bramley@arm.com changed reviewers:
+ jacob.bramley@arm.com

[jbramley, 2016-06-21 08:31:50]

https://codereview.chromium.org/2079393003/diff/1/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/2079393003/diff/1/src/arm64/builtins-arm64.cc...
src/arm64/builtins-arm64.cc:2801: __ CallRuntime(Runtime::kToNumber);
Why not kStringToNumber here?

[Benedikt Meurer, 2016-06-21 08:32:49]

LGTM once comments addressed.

https://codereview.chromium.org/2079393003/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/2079393003/diff/1/src/arm/builtins-arm.cc#new...
src/arm/builtins-arm.cc:2708: __ CallRuntime(Runtime::kToNumber);
kStringToNumber here and on all other ports.

[ahaas, 2016-06-21 08:52:58]

https://codereview.chromium.org/2079393003/diff/1/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/2079393003/diff/1/src/arm/builtins-arm.cc#new...
src/arm/builtins-arm.cc:2708: __ CallRuntime(Runtime::kToNumber);
On 2016/06/21 at 08:32:48, Benedikt Meurer wrote:
> kStringToNumber here and on all other ports.

done.

https://codereview.chromium.org/2079393003/diff/1/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/2079393003/diff/1/src/arm64/builtins-arm64.cc...
src/arm64/builtins-arm64.cc:2801: __ CallRuntime(Runtime::kToNumber);
On 2016/06/21 at 08:31:50, jbramley wrote:
> Why not kStringToNumber here?

Thanks for noticing.

[ahaas, 2016-06-21 09:23:14]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-06-21 09:23:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2079393003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-06-21 09:23:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079393003/20001

[commit-bot: I haz the power, 2016-06-21 09:26:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 09:27:07]

Description was changed from

==========
[builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of
TailCallRuntime

With the tail call, pointers to the JS heap could be pushed on a
js-to-wasm frame. On the js-to-wasm frame, however, this pointer would
not be updated by the GC.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com
BUG=617084
TEST=mjsunit/wasm/gc-frame.js:GCInJSToWasmTest()
==========

to

==========
[builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of
TailCallRuntime

With the tail call, pointers to the JS heap could be pushed on a
js-to-wasm frame. On the js-to-wasm frame, however, this pointer would
not be updated by the GC.

R=bmeurer@chromium.org, v8-arm-ports@googlegroups.com,
v8-mips-ports@googlegroups.com
BUG=617084
TEST=mjsunit/wasm/gc-frame.js:GCInJSToWasmTest()

Committed: https://crrev.com/b5c69cbf39192b7efc12ae40406c8bd55a44419b
Cr-Commit-Position: refs/heads/master@{#37132}
==========

[commit-bot: I haz the power, 2016-06-21 09:27:08]

Patchset 2 (id:??) landed as
https://crrev.com/b5c69cbf39192b7efc12ae40406c8bd55a44419b
Cr-Commit-Position: refs/heads/master@{#37132}