[wasm] Consolidated code size reporting as instantiation concern.

[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with
re-running benchmarks), and also consolidates the responsibility of
size reporting within the instantiation method, away from the various
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.

BUG=

Committed: https://crrev.com/a03701ec0db1c264706fee69e77ea0845982bcd6
Cr-Commit-Position: refs/heads/master@{#37120}

[Mircea Trofin, 2016-06-20 16:06:49]

Description was changed from

==========
[wasm] Consolidated code size reporting as an instantiation concern.

BUG=
==========

to

==========
[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with 
re-running benchmarks), and also consolidates the responsibility of 
size reporting within the instantiation method, away from the various 
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.
 
BUG=
==========

[Mircea Trofin, 2016-06-20 16:06:50]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org, clemensh@chromium.org

[Clemens Hammacher, 2016-06-20 16:13:04]

https://codereview.chromium.org/2079353002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2079353002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:851: CodeStats code_stats;
Now in this design it would make sense to pull the check for
FLAG_print_wasm_code_size out from CodeStats to this code here.

[Mircea Trofin, 2016-06-20 22:47:03]

https://codereview.chromium.org/2079353002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2079353002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:851: CodeStats code_stats;
On 2016/06/20 16:13:04, Clemens Hammacher wrote:
> Now in this design it would make sense to pull the check for
> FLAG_print_wasm_code_size out from CodeStats to this code here.

Makes sense - done.

[bradnelson, 2016-06-21 02:35:28]

lgtm

[bradnelson, 2016-06-21 02:35:42]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-06-21 02:35:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079353002/20001

[commit-bot: I haz the power, 2016-06-21 02:37:30]

Description was changed from

==========
[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with 
re-running benchmarks), and also consolidates the responsibility of 
size reporting within the instantiation method, away from the various 
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.
 
BUG=
==========

to

==========
[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with 
re-running benchmarks), and also consolidates the responsibility of 
size reporting within the instantiation method, away from the various 
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.
 
BUG=
==========

[commit-bot: I haz the power, 2016-06-21 02:37:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 02:38:01]

Description was changed from

==========
[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with 
re-running benchmarks), and also consolidates the responsibility of 
size reporting within the instantiation method, away from the various 
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.
 
BUG=
==========

to

==========
[wasm] Consolidated code size reporting as an instantiation concern.

When separating compile from instantiation, I accidentally elided size
reporting for wasm functions. This change fixes that (verified with
re-running benchmarks), and also consolidates the responsibility of
size reporting within the instantiation method, away from the various
compile phases.

We should probably rethink this reporting when we move wasm codegen
off the JS Heap, if the wasm module code ends up being shared.

BUG=

Committed: https://crrev.com/a03701ec0db1c264706fee69e77ea0845982bcd6
Cr-Commit-Position: refs/heads/master@{#37120}
==========

[commit-bot: I haz the power, 2016-06-21 02:38:02]

Patchset 2 (id:??) landed as
https://crrev.com/a03701ec0db1c264706fee69e77ea0845982bcd6
Cr-Commit-Position: refs/heads/master@{#37120}