Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2079333003: 🎃 Fix incremental install on latest version of Android N (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incremental install on latest version of Android N Looks like the libraryloader.so always loads fine, but when the ModernLinker is enabled, loading of subsequent libraries fails. This change just forces the LegacyLinker to be used when incrmental install is detected. BUG=621572 Committed: https://crrev.com/f034867a98cfe868d652ca73e97f07be60d5f02d Cr-Commit-Position: refs/heads/master@{#401157}

Patch Set 1 #

Patch Set 2 : remove dependent patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
agrieve
It's conceivable that there's a better fix that involves updating the modern linker to respect ...
4 years, 6 months ago (2016-06-20 17:32:17 UTC) #2
Torne
There isn't a public API to update LD_LIBRARY_PATH for the system linker (which is what ...
4 years, 6 months ago (2016-06-21 11:09:09 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2070633002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-21 13:38:43 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2070633002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-21 16:40:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079333003/20001
4 years, 6 months ago (2016-06-22 00:31:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 01:48:25 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 01:53:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f034867a98cfe868d652ca73e97f07be60d5f02d
Cr-Commit-Position: refs/heads/master@{#401157}

Powered by Google App Engine
This is Rietveld 408576698