Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2079323003: Enable gn release builds of remoting_client_plugin_newlib (Closed)

Created:
4 years, 6 months ago by brucedawson
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable gn release builds of remoting_client_plugin_newlib Windows gn debug builds of remoting_client_plugin_newlib OOM the 32-bit arm-nacl-ld.gold.exe. However we only need to build these in release builds. BUG=584516 Committed: https://crrev.com/cb3480d715bfb3585624889e2a5106bbb548b57b Cr-Commit-Position: refs/heads/master@{#400890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M remoting/webapp/build_template.gni View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brucedawson
A simple way to enable remoting_client_plugin_newlib is to do it just for release builds. If ...
4 years, 6 months ago (2016-06-21 00:00:10 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 00:04:48 UTC) #3
Sergey Ulanov
lgtm
4 years, 6 months ago (2016-06-21 00:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079323003/1
4 years, 6 months ago (2016-06-21 03:12:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 04:17:15 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 04:19:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb3480d715bfb3585624889e2a5106bbb548b57b
Cr-Commit-Position: refs/heads/master@{#400890}

Powered by Google App Engine
This is Rietveld 408576698