Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2079313002: Revert of Update Zlib to version 1.2.8 (Closed)

Created:
4 years, 6 months ago by Jamie Madill
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update Zlib to version 1.2.8 (patchset #10 id:220001 of https://codereview.chromium.org/1955383002/ ) Reason for revert: Broke the Windows Debug GPU FYI builder: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/41421 fx_zlib.gzlib.obj : error LNK2005: _gzopen_w already defined in zlib.gzlib.obj initial\chrome.dll : fatal error LNK1169: one or more multiply defined symbols found Possibly because they use shared components with a GYP build. Original issue's description: > Update Zlib to version 1.2.8 > > merge the latest open source zlib into chromium external projects > > Version 1.2.8 fixes a very rare bug in decompression. All users are encouraged to upgrade immediately. Version 1.2.8 also has these improvements: > - Add new inflateGetDictionary() function > - Fix bug where gzopen() immediately followed by gzclose() would write an empty file instead of an empty gzip stream. > - Fix bug in gzclose() when gzwrite() runs out of memory > Version 1.2.7 has many portability improvements over 1.2.6, and has these enhancements: > - Fix bug in gzclose_w() when gzwrite() fails to allocate memory > - Add "x" (O_EXCL) and "e" (O_CLOEXEC) modes support to gzopen() > - Add gzopen_w() in Windows for wide character path names > - Fix type mismatch between get_crc_table() and crc_table > Version 1.2.6 has many changes over 1.2.5, including these improvements: > - gzread() can now read a file that is being written concurrently > - gzgetc() is now a macro for increased speed > - Added a 'T' option to gzopen() for transparent writing (no compression) > - Added deflatePending() to return the amount of pending output > - Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode > - deflatePrime() can now insert bits in the middle of the stream > - ./configure now creates a configure.log file with all of the results > - Added a ./configure --solo option to compile zlib with no dependency on any libraries > - Fixed a problem with large file support macros > - Fixed a bug in contrib/puff > - Many portability improvements > > BUG=610615 > R=agl@chromium.org > R=gavinp@chromium.org > > Committed: https://crrev.com/a50849ae9ba1b2fad47905db521463b3bf085883 > Cr-Commit-Position: refs/heads/master@{#400647} TBR=agl@chromium.org,gavinp@chromium.org,khasim.mohammed@linaro.org,jiadong.zhu@linaro.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610615 Committed: https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3 Cr-Commit-Position: refs/heads/master@{#400670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1126 lines, -3164 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 11 chunks +23 lines, -22 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/zlib/README.chromium View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/zlib/adler32.c View 5 chunks +29 lines, -39 lines 0 comments Download
M third_party/zlib/compress.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/contrib/minizip/crypt.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/zlib/contrib/minizip/ioapi.h View 4 chunks +1 line, -9 lines 0 comments Download
M third_party/zlib/contrib/minizip/ioapi.c View 5 chunks +5 lines, -17 lines 0 comments Download
M third_party/zlib/contrib/minizip/iowin32.c View 10 chunks +13 lines, -92 lines 0 comments Download
M third_party/zlib/contrib/minizip/miniunz.c View 8 chunks +14 lines, -26 lines 0 comments Download
M third_party/zlib/contrib/minizip/minizip.c View 8 chunks +13 lines, -26 lines 0 comments Download
M third_party/zlib/contrib/minizip/mztools.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/zlib/contrib/minizip/mztools.c View 3 chunks +7 lines, -17 lines 0 comments Download
M third_party/zlib/contrib/minizip/unzip.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/zlib/contrib/minizip/unzip.c View 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/zlib/contrib/minizip/zip.c View 7 chunks +6 lines, -9 lines 0 comments Download
M third_party/zlib/crc32.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/crc32.c View 14 chunks +52 lines, -35 lines 0 comments Download
M third_party/zlib/deflate.h View 6 chunks +6 lines, -8 lines 0 comments Download
M third_party/zlib/deflate.c View 31 chunks +75 lines, -200 lines 0 comments Download
M third_party/zlib/google.patch View 5 chunks +52 lines, -222 lines 0 comments Download
M third_party/zlib/gzguts.h View 6 chunks +13 lines, -90 lines 0 comments Download
M third_party/zlib/gzlib.c View 18 chunks +54 lines, -149 lines 0 comments Download
M third_party/zlib/gzread.c View 21 chunks +252 lines, -197 lines 0 comments Download
M third_party/zlib/gzwrite.c View 20 chunks +76 lines, -122 lines 0 comments Download
M third_party/zlib/infback.c View 4 chunks +4 lines, -12 lines 0 comments Download
M third_party/zlib/inffast.c View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/zlib/inffixed.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/zlib/inflate.c View 21 chunks +53 lines, -85 lines 0 comments Download
M third_party/zlib/inftrees.c View 6 chunks +39 lines, -15 lines 0 comments Download
M third_party/zlib/mixed-source.patch View 24 chunks +26 lines, -28 lines 0 comments Download
M third_party/zlib/mozzconf.h View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/zlib/simd.patch View 1 chunk +0 lines, -1198 lines 0 comments Download
M third_party/zlib/trees.c View 11 chunks +36 lines, -18 lines 0 comments Download
M third_party/zlib/uncompr.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/zconf.h View 11 chunks +62 lines, -145 lines 0 comments Download
M third_party/zlib/zlib.h View 33 chunks +115 lines, -276 lines 0 comments Download
M third_party/zlib/zutil.h View 10 chunks +63 lines, -42 lines 0 comments Download
M third_party/zlib/zutil.c View 4 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jamie Madill
Created Revert of Update Zlib to version 1.2.8
4 years, 6 months ago (2016-06-20 13:57:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079313002/1
4 years, 6 months ago (2016-06-20 13:57:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 13:59:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/43770253ccc0425c4edde966e56b3e68955cc4d3 Cr-Commit-Position: refs/heads/master@{#400670}
4 years, 6 months ago (2016-06-20 14:01:38 UTC) #7
agl
4 years, 6 months ago (2016-06-20 15:14:40 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698