Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2079283002: [iOS/GN] Allow compilation with system clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/clang/clang.gni ('k') | build/config/ios/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 481b004c6d1ac308a2a693d8f46523c42d352a79..e3b9c45e7966a084f0bb89271f62483986b43d6d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1007,17 +1007,14 @@ config("default_warnings") {
"-Wno-inconsistent-missing-override",
]
- # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
- # always have different versions. Certain flags may not be recognized by
- # one version or the other.
+ # Chrome's hermetic Clang compiler, NaCl's Clang compiler and Xcode's Clang
+ # compiler will almost always have different versions. Certain flags may not
+ # be recognized by one version or the other.
if (!is_nacl) {
# Flags NaCl (Clang 3.7) does not recognize.
cflags += [
# TODO(thakis): Enable this, crbug.com/507717
"-Wno-shift-negative-value",
-
- # TODO(thakis): https://crbug.com/604888
- "-Wno-undefined-var-template",
]
if (llvm_force_head_revision) {
@@ -1027,6 +1024,14 @@ config("default_warnings") {
]
}
}
+ if (!is_nacl && !use_xcode_clang) {
+ # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not
+ # recognize.
+ cflags += [
+ # TODO(thakis): https://crbug.com/604888
+ "-Wno-undefined-var-template",
+ ]
+ }
}
}
« no previous file with comments | « build/config/clang/clang.gni ('k') | build/config/ios/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698