[iOS/GN] Allow compilation with system clang.

build/config/clang/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("clang.gni")
 import("//build/config/chromecast_build.gni")
 
 config("find_bad_constructs") {
   if (clang_use_chrome_plugins) {
     cflags = []
@@ skipping 42 matching lines @@
 
     if ((is_linux || is_android) && !is_chromecast) {
       cflags += [
         "-Xclang",
         "-plugin-arg-find-bad-constructs",
         "-Xclang",
         "check-ipc",
       ]
     }
   }
+
+  # TODO(ios): Remove once Xcode's libc++ has LLVM r256325.
+  if (use_system_clang && is_ios) {

[Nico, 2016/06/21 12:30:59]

can we call this use_xcode_clang please? i don't want people to try and add
"system clang" support for builds other than ios.

(also, have you experimented with shipping a chromium clang release? what are
blockers?)

[sdefresne, 2016/06/21 13:21:58]

I've renamed the variable to "is_clang_xcode" to be closer to the gyp name
("clang_xcode") while still following the same naming convention than "is_clang"
(named "clang" with gyp).

Regarding shipping a build of Chrome on iOS using ToT clang, if/when we do it we
want to decouple this from the transition from gyp to gn.

[justincohen, 2016/06/22 09:15:07]

We haven't tried shipping with a chromium clang.

We sometimes see features added to Xcode's clang that are required to support
some new new iOS thing.  While those features do eventually make it to chromium
clang, we'd have delay support.

I don't know of anything blocking us today, but who knows what the next Xcode
beta will include.

[Nico, 2016/06/22 14:30:27]

The last two times (bitcode and...uh, don't remember, there was one other thing.
arm64?) it took like a month, which doesn't seem so terrible.

+    cflags += [
+      "-isystem",
+      rebase_path("//third_party/llvm-build/Release+Asserts/include/c++/v1",
+                  root_build_dir),
+    ]
+  }
 }
 
 # Enables some extra Clang-specific warnings. Some third-party code won't
 # compile with these so may want to remove this config.
 config("extra_warnings") {
   cflags = [
     "-Wheader-hygiene",
 
     # Warns when a const char[] is converted to bool.
     "-Wstring-conversion",
   ]
 }